harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sian January (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (HARMONY-5899) [classlib][pack200] ByteCode.equals() can be optimized
Date Tue, 08 Jul 2008 13:31:07 GMT

     [ https://issues.apache.org/jira/browse/HARMONY-5899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sian January resolved HARMONY-5899.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 5.0M7

Patch applied at r674816.  Please check that it was applied as you expected.

> [classlib][pack200] ByteCode.equals() can be optimized
> ------------------------------------------------------
>
>                 Key: HARMONY-5899
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5899
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>    Affects Versions: 5.0M6
>         Environment: Pack200 HEAD
>            Reporter: Andrew Cornwall
>            Assignee: Sian January
>             Fix For: 5.0M7
>
>         Attachments: main.patch
>
>
> Now that HARMONY-5889 has been incorporated, the .equals() method for ByteCode can be
simplified. This leads to some performance increase.
> I've also modified the hashCode() method. It now leads to fewer collisions. Now there
are as few as if Object.hashCode() were used instead. (I didn't use Object.hashCode() because
the abstract hashCode() in ClassFileEntry means I'd have to put a helper method in ClassFileEntry
- and if the code in ByteCode is just as fast, why do that?)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message