harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Hindess (JIRA)" <j...@apache.org>
Subject [jira] Created: (HARMONY-5926) [classlib] [linuxfont] LinuxNativeFont.c needs code review
Date Thu, 31 Jul 2008 14:46:31 GMT
[classlib] [linuxfont] LinuxNativeFont.c needs code review
----------------------------------------------------------

                 Key: HARMONY-5926
                 URL: https://issues.apache.org/jira/browse/HARMONY-5926
             Project: Harmony
          Issue Type: Bug
          Components: Classlib
         Environment: linux
            Reporter: Mark Hindess


While looking at the issues in HARMONY-5914, I notice that there are a number of other issues
with this code.  Specifically, there are a number of clauses like:

    if (!blah) {
        ...
        throwNPException(env, "Error during blah");
    }

where the exceptions are thrown but control flow continues regardless.  Obviously, the code
should return after the exception is thrown to avoid causing more exceptions that would likely
hide the root cause.

It is probably worth doing a review of this code since I suspect there are other improvements
to be made.  I wonder however whether the test cases exercise this code sufficiently such
that we can be sure any refactoring  doesn't break anything.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message