harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Cornwall (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-5907) [classlib][pack200]CPUTF8.hashCode() is slow
Date Mon, 14 Jul 2008 16:10:33 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-5907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613359#action_12613359
] 

Andrew Cornwall commented on HARMONY-5907:
------------------------------------------

Some of these classes are set in the constructor and then never altered. In these classes,
it should be possible to generateHashCode() in the constructor, meaning we don't need to check
for hashcodeComputed in the hashCode() method.


> [classlib][pack200]CPUTF8.hashCode() is slow
> --------------------------------------------
>
>                 Key: HARMONY-5907
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5907
>             Project: Harmony
>          Issue Type: Improvement
>    Affects Versions: 5.0M6
>         Environment: Latest pack200
>            Reporter: Andrew Cornwall
>            Assignee: Sian January
>         Attachments: main.patch, pack200-hashcodes-v1.patch
>
>
> The unpack process spends a lot of time doing CPUTF8.hashCode() - which does String.hashCode().
We can save about 1.5 seconds of my 39 second test case (about 4%) by caching the hashCode.
(I thought we did this before - or maybe I dreamt it?)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message