harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Cornwall (JIRA)" <j...@apache.org>
Subject [jira] Created: (HARMONY-5888) [classlib][pack200] Segment.writeJar is writing unbuffered (performance)
Date Tue, 01 Jul 2008 18:02:45 GMT
[classlib][pack200] Segment.writeJar is writing unbuffered (performance)
------------------------------------------------------------------------

                 Key: HARMONY-5888
                 URL: https://issues.apache.org/jira/browse/HARMONY-5888
             Project: Harmony
          Issue Type: Improvement
          Components: Classlib
    Affects Versions: 5.0M6
         Environment: Pack200 head
            Reporter: Andrew Cornwall
         Attachments: main.patch

The method Segment.writeJar() is writing directly from the DataOutputStream to a JarOutputStream.
Because it is not buffered, the unpack spends a lot more time than it really needs to going
down to the file system and back.

The attached patch wraps the JarOutputStream in a BufferedOutputStream before wrapping that
in a DataOutputStream. This increases performance in my testcase by about 40% (!)

This patch also removes an extraneous flush(), since DataOutputStream.flush will send BufferedOutputStream.flush
which will send JarOutputStream.flush.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message