harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sian January (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-5882) [classlib][pack200] Performance improvements for pack200
Date Thu, 26 Jun 2008 10:31:45 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608382#action_12608382
] 

Sian January commented on HARMONY-5882:
---------------------------------------

Andrew - the latest patch is passing my tests now so I'm happy to check it in once we've resolved
the public field issue.  On this issue, I would have thought that the three methods on SegmentConstantPoolArrayCache
should be public (indexesForArrayKey, arrayIsCached and cacheArray) and then the tests can
use those methods instead of accessing the field directly.  Does that sound reasonable?

> [classlib][pack200] Performance improvements for pack200
> --------------------------------------------------------
>
>                 Key: HARMONY-5882
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5882
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>    Affects Versions: 5.0M6
>         Environment: Pack200 HEAD
>            Reporter: Andrew Cornwall
>            Assignee: Sian January
>         Attachments: Lexer.class, main.updated.patch, test.updated.patch
>
>
> Attached are some performance improvements for Pack200. They do two things:
>  1. Remove unnecessary conversions to UTF-8 in CPUTF8
>  2. Cache array lookup in SegmentConstantPool
> Hope they work - this is my first try at applying a fix since I've forked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message