harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Cornwall (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-5882) [classlib][pack200] Performance improvements for pack200
Date Tue, 24 Jun 2008 16:34:45 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607678#action_12607678
] 

Andrew Cornwall commented on HARMONY-5882:
------------------------------------------

Sian, I believe your original statement about UTF-8 (which corresponds with my beliefs) is
correct, and that Lexer.class is malformed. I say this because when I try to pack it using
Sun's tools, I see:

C:\tmp\cputf8>c:\jdk1.5.0_04\bin\pack200.exe -E9 Lexer.pack.gz Lexer.jar
Exception in thread "main" java.io.UTFDataFormatException: malformed input around byte 15
        at java.io.DataInputStream.readUTF(DataInputStream.java:612)
        at java.io.DataInputStream.readUTF(DataInputStream.java:522)
        at com.sun.java.util.jar.pack.ClassReader.readConstantPool(ClassReader.java:185)
        at com.sun.java.util.jar.pack.ClassReader.read(ClassReader.java:123)
        at com.sun.java.util.jar.pack.PackerImpl$DoPack.readClass(PackerImpl.java:491)
        at com.sun.java.util.jar.pack.PackerImpl$DoPack.run(PackerImpl.java:465)
        at com.sun.java.util.jar.pack.PackerImpl.pack(PackerImpl.java:73)
        at com.sun.java.util.jar.pack.Driver.main(Driver.java:261)

Are you by chance using your pack utility to pack it?


> [classlib][pack200] Performance improvements for pack200
> --------------------------------------------------------
>
>                 Key: HARMONY-5882
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5882
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>    Affects Versions: 5.0M6
>         Environment: Pack200 HEAD
>            Reporter: Andrew Cornwall
>            Assignee: Sian January
>         Attachments: Lexer.class, main.patch, test.patch
>
>
> Attached are some performance improvements for Pack200. They do two things:
>  1. Remove unnecessary conversions to UTF-8 in CPUTF8
>  2. Cache array lookup in SegmentConstantPool
> Hope they work - this is my first try at applying a fix since I've forked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message