harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sian January (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-5882) [classlib][pack200] Performance improvements for pack200
Date Thu, 26 Jun 2008 12:27:45 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608408#action_12608408
] 

Sian January commented on HARMONY-5882:
---------------------------------------

Sorry - I'm getting confused.  There wasn't a public field at all.  

I think the discussion about tests and private vs. public methods is more of a general discussion
that we should move to the dev list.  We have a lot of public methods in pack200 that could
be made package-private by the same reasoning if we moved the tests, so unless there are any
objections I'm going to apply the patch for this JIRA and we can discuss the general issue
on the list.

> [classlib][pack200] Performance improvements for pack200
> --------------------------------------------------------
>
>                 Key: HARMONY-5882
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5882
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>    Affects Versions: 5.0M6
>         Environment: Pack200 HEAD
>            Reporter: Andrew Cornwall
>            Assignee: Sian January
>         Attachments: Lexer.class, main.updated.patch, test.updated.patch
>
>
> Attached are some performance improvements for Pack200. They do two things:
>  1. Remove unnecessary conversions to UTF-8 in CPUTF8
>  2. Cache array lookup in SegmentConstantPool
> Hope they work - this is my first try at applying a fix since I've forked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message