harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sian January (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-5882) [classlib][pack200] Performance improvements for pack200
Date Tue, 24 Jun 2008 14:22:45 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607621#action_12607621
] 

Sian January commented on HARMONY-5882:
---------------------------------------

Andrew - I'm getting a problem with this patch running some of my longer-running tests that
aren't in the repository.  One of these tests runs javap against every class in the Harmony
swing module (unpacked with our version of unpack200) and I'm seeing the following problem
with javax.swing.text.html.parser.Lexer:

java.io.UTFDataFormatException: malformed input around byte 15
        at java.io.DataInputStream.readUTF(DataInputStream.java:612)
        at java.io.DataInputStream.readUTF(DataInputStream.java:522)
        at sun.tools.javap.ClassData.readCP(ClassData.java:151)
        at sun.tools.javap.ClassData.read(ClassData.java:81)
        at sun.tools.javap.ClassData.<init>(ClassData.java:52)
        at sun.tools.javap.JavapPrinter.<init>(JavapPrinter.java:28)
        at sun.tools.javap.Main.displayResults(Main.java:201)
        at sun.tools.javap.Main.perform(Main.java:61)
        at sun.tools.javap.Main.entry(Main.java:49)
        at sun.tools.javap.Main.main(Main.java:34)
ERROR:fatal exception
Exception in thread "main" java.lang.NullPointerException
        at sun.tools.javap.JavapPrinter.javaclassname(JavapPrinter.java:791)
        at sun.tools.javap.JavapPrinter.printclassHeader(JavapPrinter.java:60)
        at sun.tools.javap.JavapPrinter.print(JavapPrinter.java:36)
        at sun.tools.javap.Main.displayResults(Main.java:202)
        at sun.tools.javap.Main.perform(Main.java:61)
        at sun.tools.javap.Main.entry(Main.java:49)
        at sun.tools.javap.Main.main(Main.java:34)

Do you want me to attach the class file here or send it to you so you can take a closer look?

> [classlib][pack200] Performance improvements for pack200
> --------------------------------------------------------
>
>                 Key: HARMONY-5882
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5882
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>    Affects Versions: 5.0M6
>         Environment: Pack200 HEAD
>            Reporter: Andrew Cornwall
>            Assignee: Sian January
>         Attachments: main.patch, test.patch
>
>
> Attached are some performance improvements for Pack200. They do two things:
>  1. Remove unnecessary conversions to UTF-8 in CPUTF8
>  2. Cache array lookup in SegmentConstantPool
> Hope they work - this is my first try at applying a fix since I've forked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message