Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <765061638.1209659816088.JavaMail.jira@brutus>
Date: Thu, 1 May 2008 09:36:56 -0700 (PDT)
From: "Andrew Cornwall (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Closed: (HARMONY-5796) [classlib][pack200]
 Pack200UnpackerAdapter still using Segment
In-Reply-To: <1797243678.1209157915761.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HARMONY-5796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Cornwall closed HARMONY-5796.
------------------------------------


I must have been really out of it that day! Patch applied was better than expected. Thanks.

> [classlib][pack200] Pack200UnpackerAdapter still using Segment
> --------------------------------------------------------------
>
>                 Key: HARMONY-5796
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5796
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>    Affects Versions: 5.0M5
>         Environment: All pack200 Java 5
>            Reporter: Andrew Cornwall
>            Assignee: Sian January
>             Fix For: 5.0M6
>
>         Attachments: main.patch
>
>
> The Java5 Pack200UnpackerAdapter still uses the old Segment code instead of the new Archive code. Here's a quick patch:
> Index: C:/harmony/pack200workspace/Pack200 working/src/main/java5/org/apache/harmony/unpack200/Pack200UnpackerAdapter.java
> ===================================================================
> --- C:/harmony/pack200workspace/Pack200 working/src/main/java5/org/apache/harmony/unpack200/Pack200UnpackerAdapter.java	(revision 651261)
> +++ C:/harmony/pack200workspace/Pack200 working/src/main/java5/org/apache/harmony/unpack200/Pack200UnpackerAdapter.java	(working copy)
> @@ -46,13 +46,8 @@
>  					"Must specify both input and output streams");
>  		completed(0);
>  		try {
> -			while (in.available() > 0) {
> -			    new Segment().unpack(in, out);
> -				out.flush();
> -			}
> -		} catch (Pack200Exception e) {
> -			throw new IOException("Failed to unpack Jar:" + String.valueOf(e));
> -		}
> +			Archive archive = new Archive(in, out);
> +			archive.unpack();
>  		completed(1);
>  		in.close();
>  	}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.