Return-Path: Delivered-To: apmail-harmony-commits-archive@www.apache.org Received: (qmail 42685 invoked from network); 4 Apr 2008 09:48:28 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 4 Apr 2008 09:48:28 -0000 Received: (qmail 6041 invoked by uid 500); 4 Apr 2008 09:48:28 -0000 Delivered-To: apmail-harmony-commits-archive@harmony.apache.org Received: (qmail 6018 invoked by uid 500); 4 Apr 2008 09:48:28 -0000 Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list commits@harmony.apache.org Received: (qmail 6009 invoked by uid 99); 4 Apr 2008 09:48:28 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Apr 2008 02:48:28 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Apr 2008 09:47:45 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id D7D2C1A983A; Fri, 4 Apr 2008 02:48:04 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r644661 - in /harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200: BHSDCodec.java SegmentConstantPool.java Date: Fri, 04 Apr 2008 09:48:03 -0000 To: commits@harmony.apache.org From: sjanuary@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20080404094804.D7D2C1A983A@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: sjanuary Date: Fri Apr 4 02:48:02 2008 New Revision: 644661 URL: http://svn.apache.org/viewvc?rev=644661&view=rev Log: Pack200 - Code tidy up Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/BHSDCodec.java harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/SegmentConstantPool.java Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/BHSDCodec.java URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/BHSDCodec.java?rev=644661&r1=644660&r2=644661&view=diff ============================================================================== --- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/BHSDCodec.java (original) +++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/BHSDCodec.java Fri Apr 4 02:48:02 2008 @@ -56,9 +56,9 @@ private long cardinality; - private long smallest; + private final long smallest; - private long largest; + private final long largest; /** * Constructs an unsigned, non-delta Codec with the given B and H values. @@ -191,10 +191,10 @@ return z; } - private long cast32(long u) { - u = (long) ((long) ((u + Math.pow(2, 31)) % Math.pow(2, 32)) - Math.pow(2, 31)); - return u; - } +// private long cast32(long u) { +// u = (long) ((long) ((u + Math.pow(2, 31)) % Math.pow(2, 32)) - Math.pow(2, 31)); +// return u; +// } private boolean isHigh(long x) { return x>=l; Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/SegmentConstantPool.java URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/SegmentConstantPool.java?rev=644661&r1=644660&r2=644661&view=diff ============================================================================== --- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/SegmentConstantPool.java (original) +++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/SegmentConstantPool.java Fri Apr 4 02:48:02 2008 @@ -16,8 +16,6 @@ */ package org.apache.harmony.pack200; -import java.util.ArrayList; - import org.apache.harmony.pack200.bytecode.CPFieldRef; import org.apache.harmony.pack200.bytecode.CPInterfaceMethodRef; import org.apache.harmony.pack200.bytecode.CPMethodRef; @@ -25,10 +23,8 @@ import org.apache.harmony.pack200.bytecode.ConstantPoolEntry; public class SegmentConstantPool { - /** - * - */ - private CpBands bands; + + private final CpBands bands; /** * @param bands