Return-Path: Delivered-To: apmail-harmony-commits-archive@www.apache.org Received: (qmail 95913 invoked from network); 18 Apr 2008 05:12:32 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 18 Apr 2008 05:12:32 -0000 Received: (qmail 85347 invoked by uid 500); 18 Apr 2008 05:12:33 -0000 Delivered-To: apmail-harmony-commits-archive@harmony.apache.org Received: (qmail 85330 invoked by uid 500); 18 Apr 2008 05:12:33 -0000 Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list commits@harmony.apache.org Received: (qmail 85320 invoked by uid 99); 18 Apr 2008 05:12:33 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Apr 2008 22:12:32 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Apr 2008 05:11:57 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 498FB234C0DE for ; Thu, 17 Apr 2008 22:09:22 -0700 (PDT) Message-ID: <1554190471.1208495362300.JavaMail.jira@brutus> Date: Thu, 17 Apr 2008 22:09:22 -0700 (PDT) From: "Alexey Varlamov (JIRA)" To: commits@harmony.apache.org Subject: [jira] Commented: (HARMONY-5727) [port][atomic] implement port_atomic_casptr for Windows In-Reply-To: <720387052.1208209625800.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HARMONY-5727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590288#action_12590288 ] Alexey Varlamov commented on HARMONY-5727: ------------------------------------------ Alexey, MSDN is quite distinct that arguments to InterlockedCompareExchangePointer must be aligned [1]: "On a 64-bit system, the parameters are 64 bits and must be aligned on 64-bit boundaries; otherwise, the function will behave unpredictably. On a 32-bit system, the parameters are 32 bits and must be aligned on 32-bit boundaries." Yet the header already defines other port_atomic_cas* functions referring to VS intrinsics on Win64. I believe some more research is needed to set these right. [1] http://msdn2.microsoft.com/en-us/library/ms683568(VS.85).aspx > [port][atomic] implement port_atomic_casptr for Windows > ------------------------------------------------------- > > Key: HARMONY-5727 > URL: https://issues.apache.org/jira/browse/HARMONY-5727 > Project: Harmony > Issue Type: Sub-task > Components: DRLVM > Reporter: Alexei Fedotov > Attachments: atomic.patch > > > apr_atomic_casptr requires APR to be initialized, does not inline and use modern processor instructions. The patch extends port functionality to supported platforms. One day it would be better committed into APR. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.