harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eugene S. Ostrovsky (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-5525) [build][drlvm] vm build fails if no .svn data present
Date Mon, 21 Apr 2008 07:18:23 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590856#action_12590856

Eugene S. Ostrovsky commented on HARMONY-5525:

I'm afraid the patch is already outdated.
However the issue is still relevant.
AFAIU since we have source distributions for harmony one should be able to build it without
.svn data.

> [build][drlvm] vm build fails if no .svn data present
> -----------------------------------------------------
>                 Key: HARMONY-5525
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5525
>             Project: Harmony
>          Issue Type: Bug
>          Components: build - test - ci
>            Reporter: Eugene S. Ostrovsky
>            Assignee: Alexey Varlamov
>            Priority: Minor
>         Attachments: H5525.patch
> VM fails to build if there's no .svn/entries file in working_vm source directory.
> In working_vm/make/vm/vmcore.xml:
>     <target name="-check-version" if="svn.revision">
>         <uptodate property="skip.svn.stamp" 
>             srcfile="${vm.home}/.svn/entries" 
>             targetfile="${vm.home}/vmcore/include/version_svn_tag.h"/>
>     </target>
> This target checks svn.revision property as precondition. AFAIK this check is always
true because svn.revision is set to "unknown" string if svn doesn't present.
> Thus this check have no sense.
> I think it's better to use "is.svn" property instead.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message