harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Varlamov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-5692) [drlvm][build] remove apr-util and apr-iconv from the list of dependencies
Date Mon, 14 Apr 2008 11:13:06 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-5692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588543#action_12588543
] 

Alexey Varlamov commented on HARMONY-5692:
------------------------------------------

Alexei, I strongly encourage you split the patch at least in 2 parts (new logger impl vs updated
log statements), and probably even proceed with several steps in integration - e.g. at first
just rename logging macros and commit updated logging statements (better component by component),
then finalize the new impl and commit it last. Otherwise such huge patch is nightmare for
review/ commit(especially given massive ongoing updates in VM interfaces).

Now on the checklist:
1) Sorry for my English, I meant ALL saying ANY. That is, equivalent of "-Xverbose" or "-Xverbose:*"
in current logger, etc
2) you can find parsing list of categories in deleted code in the diff, let's do this at once;
3) Thanks, yet I'd suggest just using "-" sign before category name (e.g. "-Xtrace:*,-gc,-enum");
4) Impl should be the opposite, (is_info_enabled checks both ->trace and ->info lists);
5) This is really optional feature, may skip this time. Support file per category is easy,
just add one more field (File*) to struct Category and if it is set, redirect output there
instead of a common file.  
6) Any chance for a logging/l10n HOWTO?

And again, please, split the patch and let's proceed in steps.

> [drlvm][build] remove apr-util and apr-iconv from the list of dependencies 
> ---------------------------------------------------------------------------
>
>                 Key: HARMONY-5692
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5692
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Alexei Fedotov
>         Attachments: logger.1.patch, logger.2.patch, logger.3.patch, logger.4.patch,
logger.5.patch, logger.patch, logger.test.patch
>
>
> Two optional apr modules (apr-util and apr-iconv) modules are not used by DRLVM. Removing
them speeds up a build process.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message