[ https://issues.apache.org/jira/browse/HARMONY-5679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585018#action_12585018
]
Tim Ellison commented on HARMONY-5679:
--------------------------------------
Applied patch utf8_decode_test.patch to NIO_CHAR module at repo revision r644228.
It is preferred that you don't include reformatting in a patch with functional changes since
it makes the functional changes harder to review. Either include a comment on the JIRA asking
that the code is reformatted (in which case it is trivial for people to do the <ctrl>+F)
or submit the reformatting as a separate patch.
Thanks for your dedicated work on this issue. Please verify that the issue can now be closed.
> [classlib][archive] UTF-8 decoder & Attributes.Name.hashCode optimizations
> --------------------------------------------------------------------------
>
> Key: HARMONY-5679
> URL: https://issues.apache.org/jira/browse/HARMONY-5679
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Alexei Fedotov
> Assignee: Tim Ellison
> Attachments: attr_name_hash.patch, utf8_decode.patch, utf8_decode_pos.patch,
utf8_decode_review.patch, utf8_decode_test.patch
>
>
> Found a bug in UTF-8 patch. pos++ is not incremented on fast path. Seems we don't have
a test for this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
|