harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Varlamov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-5692) [drlvm][build] remove apr-util and apr-iconv from the list of dependencies
Date Fri, 11 Apr 2008 07:16:04 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-5692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587871#action_12587871
] 

Alexey Varlamov commented on HARMONY-5692:
------------------------------------------

Wow! Alexei, I see this is not a mere build dependency change, but a whole new feature: 100%
complete Invocation API compatibility for invocation hooks. And IMO this is a killer argument
against any enhancements and cool features provided by log4cxx (more the so as most of log4cxx
capabilities are not used in our practice).
I suggest you gain wider response from dev-list about this approach.
Here are my considerations:
1) Please try to keep a set of most useful features and user interface compartible with the
current impl:
 - ability to enable/disable ANY category - rather than support only per-category control;
 - ability to specify a list of categories (-Xtrace:init,jni,enum);
 - ability to suppress certain categories (e.g. trace all but GC and threading); 
 - would be nice to keep relations between logging levels (e.g. if tracing is enabled then
info is enabled as well);
 - would be nice to support file per category - should not be too expensive.
2) Please document changes in concepts, use cases, defaults - e.g. WARN now have no categories
(correct?), etc.

Regarding the patch itself:
- switching C++ logging to C is not always clearly reasonable (performance considerations?)
and not quite consistent.
- port_nanotimer() is not suitable for timestamps, only for measuring time intervals.

Overall, really nice shot! Please go on :)

> [drlvm][build] remove apr-util and apr-iconv from the list of dependencies 
> ---------------------------------------------------------------------------
>
>                 Key: HARMONY-5692
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5692
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Alexei Fedotov
>         Attachments: logger.1.patch, logger.patch
>
>
> Two optional apr modules (apr-util and apr-iconv) modules are not used by DRLVM. Removing
them speeds up a build process.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message