harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjanu...@apache.org
Subject svn commit: r646384 - /harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/
Date Wed, 09 Apr 2008 14:42:04 GMT
Author: sjanuary
Date: Wed Apr  9 07:41:59 2008
New Revision: 646384

URL: http://svn.apache.org/viewvc?rev=646384&view=rev
Log:
Pack200 - Added some more Javadoc

Modified:
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/AnnotationDefaultAttribute.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/Attribute.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/BCIRenumberedAttribute.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ByteCode.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPClass.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPConstant.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPConstantNumber.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPDouble.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPField.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPFieldRef.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPFloat.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPInteger.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPInterfaceMethodRef.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPLong.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPMember.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPMethod.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPMethodRef.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPNameAndType.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPRef.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPString.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPUTF8.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ClassConstantPool.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ClassFile.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ClassFileEntry.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CodeAttribute.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ConstantPoolEntry.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ConstantValueAttribute.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/DeprecatedAttribute.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/EnclosingMethodAttribute.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ExceptionTableEntry.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ExceptionsAttribute.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/InnerClassesAttribute.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/LineNumberTableAttribute.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/LocalVariableTableAttribute.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/LocalVariableTypeTableAttribute.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/NewAttribute.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/OperandManager.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/RuntimeVisibleorInvisibleAnnotationsAttribute.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/RuntimeVisibleorInvisibleParameterAnnotationsAttribute.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/SignatureAttribute.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/SourceFileAttribute.java

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/AnnotationDefaultAttribute.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/AnnotationDefaultAttribute.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/AnnotationDefaultAttribute.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/AnnotationDefaultAttribute.java Wed Apr  9 07:41:59 2008
@@ -20,11 +20,11 @@
 import java.io.IOException;
 
 /**
- * AnnotationDefault attribute
+ * AnnotationDefault class file attribute
  */
 public class AnnotationDefaultAttribute extends AnnotationsAttribute {
 
-    private ElementValue element_value;
+    private final ElementValue element_value;
 
     private static final CPUTF8 attributeName = new CPUTF8("AnnotationDefault", ClassConstantPool.DOMAIN_ATTRIBUTEASCIIZ);
 

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/Attribute.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/Attribute.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/Attribute.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/Attribute.java Wed Apr  9 07:41:59 2008
@@ -19,6 +19,9 @@
 import java.io.DataOutputStream;
 import java.io.IOException;
 
+/**
+ * Abstract superclass for class file attributes
+ */
 public abstract class Attribute extends ClassFileEntry {
     protected final CPUTF8 attributeName;
 

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/BCIRenumberedAttribute.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/BCIRenumberedAttribute.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/BCIRenumberedAttribute.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/BCIRenumberedAttribute.java Wed Apr  9 07:41:59 2008
@@ -22,6 +22,10 @@
 
 import org.apache.harmony.pack200.Pack200Exception;
 
+/**
+ * Abstract superclass for attributes that have some part encoded with a BCI
+ * renumbering
+ */
 public abstract class BCIRenumberedAttribute extends Attribute {
 
     protected boolean renumbered = false;

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ByteCode.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ByteCode.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ByteCode.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ByteCode.java Wed Apr  9 07:41:59 2008
@@ -22,6 +22,9 @@
 import org.apache.harmony.pack200.Segment;
 import org.apache.harmony.pack200.bytecode.forms.ByteCodeForm;
 
+/**
+ * A bytecode class file entry.
+ */
 public class ByteCode extends ClassFileEntry {
 
 	public static ByteCode getByteCode(int opcode) {

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPClass.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPClass.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPClass.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPClass.java Wed Apr  9 07:41:59 2008
@@ -19,6 +19,9 @@
 import java.io.DataOutputStream;
 import java.io.IOException;
 
+/**
+ * Constant pool entry for a class
+ */
 public class CPClass extends ConstantPoolEntry {
 
 	private int index;

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPConstant.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPConstant.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPConstant.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPConstant.java Wed Apr  9 07:41:59 2008
@@ -16,7 +16,10 @@
  */
 package org.apache.harmony.pack200.bytecode;
 
-
+/**
+ * Abstract superclass for constant pool constant entries such as numbers or
+ * Strings
+ */
 public abstract class CPConstant extends ConstantPoolEntry {
 
 	private final Object value;
@@ -51,14 +54,14 @@
 		return true;
 	}
 
-
 	public int hashCode() {
 		final int PRIME = 31;
 		int result = 1;
 		result = PRIME * result + ((value == null) ? 0 : value.hashCode());
 		return result;
 	}
+
 	protected Object getValue() {
 		return value;
 	}
-}
+}
\ No newline at end of file

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPConstantNumber.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPConstantNumber.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPConstantNumber.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPConstantNumber.java Wed Apr  9 07:41:59 2008
@@ -16,7 +16,9 @@
  */
 package org.apache.harmony.pack200.bytecode;
 
-
+/**
+ * Abstract superclass for constant pool entries that are numbers.
+ */
 public abstract class CPConstantNumber extends CPConstant {
 
 	public CPConstantNumber(byte tag, Object value) {

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPDouble.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPDouble.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPDouble.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPDouble.java Wed Apr  9 07:41:59 2008
@@ -19,6 +19,9 @@
 import java.io.DataOutputStream;
 import java.io.IOException;
 
+/**
+ * Double constant pool entry.
+ */
 public class CPDouble extends CPConstantNumber {
 
     public CPDouble(Double value) {

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPField.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPField.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPField.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPField.java Wed Apr  9 07:41:59 2008
@@ -18,6 +18,9 @@
 
 import java.util.List;
 
+/**
+ * Field constant pool entry.
+ */
 public class CPField extends CPMember {
 
 	public CPField(CPUTF8 name, CPUTF8 descriptor, long flags, List attributes) {

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPFieldRef.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPFieldRef.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPFieldRef.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPFieldRef.java Wed Apr  9 07:41:59 2008
@@ -19,11 +19,14 @@
 import java.io.DataOutputStream;
 import java.io.IOException;
 
+/**
+ * Field reference constant pool entry.
+ */
 public class CPFieldRef extends ConstantPoolEntry {
 
 	CPClass className;
 	transient int classNameIndex;
-	private CPNameAndType nameAndType;
+	private final CPNameAndType nameAndType;
 	transient int nameAndTypeIndex;
 
 	public CPFieldRef(CPClass className, CPNameAndType descriptor) {

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPFloat.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPFloat.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPFloat.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPFloat.java Wed Apr  9 07:41:59 2008
@@ -19,6 +19,9 @@
 import java.io.DataOutputStream;
 import java.io.IOException;
 
+/**
+ * Float constant pool entry.
+ */
 public class CPFloat extends CPConstantNumber {
 
     public CPFloat(Float value) {

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPInteger.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPInteger.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPInteger.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPInteger.java Wed Apr  9 07:41:59 2008
@@ -19,6 +19,9 @@
 import java.io.DataOutputStream;
 import java.io.IOException;
 
+/**
+ * Integer constant pool entry.
+ */
 public class CPInteger extends CPConstantNumber {
 
     public CPInteger(Integer value) {

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPInterfaceMethodRef.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPInterfaceMethodRef.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPInterfaceMethodRef.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPInterfaceMethodRef.java Wed Apr  9 07:41:59 2008
@@ -16,6 +16,9 @@
  */
 package org.apache.harmony.pack200.bytecode;
 
+/**
+ * Interface method reference constant pool entry.
+ */
 public class CPInterfaceMethodRef extends CPRef {
 
 	public CPInterfaceMethodRef(CPClass className, CPNameAndType descriptor) {

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPLong.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPLong.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPLong.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPLong.java Wed Apr  9 07:41:59 2008
@@ -19,6 +19,9 @@
 import java.io.DataOutputStream;
 import java.io.IOException;
 
+/**
+ * Long constant pool entry.
+ */
 public class CPLong extends CPConstantNumber {
 
     public CPLong(Long value) {

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPMember.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPMember.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPMember.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPMember.java Wed Apr  9 07:41:59 2008
@@ -22,6 +22,9 @@
 import java.util.Iterator;
 import java.util.List;
 
+/**
+ * Superclass for member constant pool entries, such as fields or methods.
+ */
 public class CPMember extends ClassFileEntry {
 
 	List attributes;

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPMethod.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPMethod.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPMethod.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPMethod.java Wed Apr  9 07:41:59 2008
@@ -18,6 +18,9 @@
 
 import java.util.List;
 
+/**
+ * Method constant pool entry.
+ */
 public class CPMethod extends CPMember {
 
 	public CPMethod(CPUTF8 name, CPUTF8 descriptor, long flags, List attributes) {

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPMethodRef.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPMethodRef.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPMethodRef.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPMethodRef.java Wed Apr  9 07:41:59 2008
@@ -16,6 +16,9 @@
  */
 package org.apache.harmony.pack200.bytecode;
 
+/**
+ * Method reference constant pool entry.
+ */
 public class CPMethodRef extends CPRef {
 
 	public CPMethodRef(CPClass className, CPNameAndType descriptor) {

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPNameAndType.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPNameAndType.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPNameAndType.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPNameAndType.java Wed Apr  9 07:41:59 2008
@@ -21,6 +21,9 @@
 
 import org.apache.harmony.pack200.SegmentUtils;
 
+/**
+ * Name and Type pair constant pool entry.
+ */
 public class CPNameAndType extends ConstantPoolEntry {
 
 	CPUTF8 descriptor;

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPRef.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPRef.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPRef.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPRef.java Wed Apr  9 07:41:59 2008
@@ -19,6 +19,10 @@
 import java.io.DataOutputStream;
 import java.io.IOException;
 
+/**
+ * Abstract superclass for reference constant pool entries, such as a method or field
+ * reference.
+ */
 public abstract class CPRef extends ConstantPoolEntry {
 
 	CPClass className;

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPString.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPString.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPString.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPString.java Wed Apr  9 07:41:59 2008
@@ -19,10 +19,13 @@
 import java.io.DataOutputStream;
 import java.io.IOException;
 
+/**
+ * String constant pool entry.
+ */
 public class CPString extends CPConstant {
 
     private transient int nameIndex;
-	private CPUTF8 name;
+	private final CPUTF8 name;
 
     public CPString(CPUTF8 value) {
 		super(ConstantPoolEntry.CP_String, value);

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPUTF8.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPUTF8.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPUTF8.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CPUTF8.java Wed Apr  9 07:41:59 2008
@@ -20,6 +20,9 @@
 import java.io.IOException;
 import java.io.UnsupportedEncodingException;
 
+/**
+ * UTF8 constant pool entry, used for storing long Strings.
+ */
 public class CPUTF8 extends ConstantPoolEntry {
 
     private final String utf8;

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ClassConstantPool.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ClassConstantPool.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ClassConstantPool.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ClassConstantPool.java Wed Apr  9 07:41:59 2008
@@ -25,7 +25,9 @@
 
 import org.apache.harmony.pack200.Segment;
 
-
+/**
+ * The Class constant pool
+ */
 public class ClassConstantPool {
 
     // These are the domains in sorted order.
@@ -52,7 +54,7 @@
     public String toString() {
         return entries.toString();
     }
-    private List others = new ArrayList(500);
+    private final List others = new ArrayList(500);
     private List entries = new ArrayList(500);
 
     private boolean resolved;

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ClassFile.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ClassFile.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ClassFile.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ClassFile.java Wed Apr  9 07:41:59 2008
@@ -19,11 +19,14 @@
 import java.io.DataOutputStream;
 import java.io.IOException;
 
-
+/**
+ * ClassFile is used to represent and write out Java class files.
+ */
 public class ClassFile {
+
 	public int major;
 	public int minor;
-	private int magic = 0xCAFEBABE;
+	private final int magic = 0xCAFEBABE;
 	public ClassConstantPool pool = new ClassConstantPool();
 	public int accessFlags;
 	public int thisClass;

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ClassFileEntry.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ClassFileEntry.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ClassFileEntry.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ClassFileEntry.java Wed Apr  9 07:41:59 2008
@@ -19,7 +19,11 @@
 import java.io.DataOutputStream;
 import java.io.IOException;
 
+/**
+ * The abstract superclass for all types of class file entries.
+ */
 public abstract class ClassFileEntry {
+
 	protected static final ClassFileEntry[] NONE = new ClassFileEntry[0];
 	private boolean resolved;
 

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CodeAttribute.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CodeAttribute.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CodeAttribute.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/CodeAttribute.java Wed Apr  9 07:41:59 2008
@@ -25,6 +25,7 @@
 import org.apache.harmony.pack200.Segment;
 
 public class CodeAttribute extends BCIRenumberedAttribute {
+
     public List attributes = new ArrayList();
     // instances
     public List byteCodeOffsets = new ArrayList();
@@ -37,7 +38,7 @@
 
     public CodeAttribute(int maxStack, int maxLocals, byte codePacked[],
             Segment segment, OperandManager operandManager, List exceptionTable) {
-        super(attributeName); //$NON-NLS-1$
+        super(attributeName);
         this.maxLocals = maxLocals;
         this.maxStack = maxStack;
         this.codeLength = 0;
@@ -184,4 +185,4 @@
             entry.renumber(byteCodeOffsets);
         }
     }
-}
+}
\ No newline at end of file

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ConstantPoolEntry.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ConstantPoolEntry.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ConstantPoolEntry.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ConstantPoolEntry.java Wed Apr  9 07:41:59 2008
@@ -20,7 +20,7 @@
 import java.io.IOException;
 
 /**
- *
+ * Abstract superclass for constant pool entries
  */
 public abstract class ConstantPoolEntry extends ClassFileEntry {
 	public static final byte CP_Class = 7;

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ConstantValueAttribute.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ConstantValueAttribute.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ConstantValueAttribute.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ConstantValueAttribute.java Wed Apr  9 07:41:59 2008
@@ -19,10 +19,14 @@
 import java.io.DataOutputStream;
 import java.io.IOException;
 
+/**
+ * An {@link Attribute} representing a constant.
+ */
 public class ConstantValueAttribute extends Attribute {
-	private int constantIndex;
 
-	private ClassFileEntry entry;
+    private int constantIndex;
+
+	private final ClassFileEntry entry;
 
     private static final CPUTF8 attributeName = new CPUTF8(
             "ConstantValue", ClassConstantPool.DOMAIN_ATTRIBUTEASCIIZ); //$NON-NLS-1$

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/DeprecatedAttribute.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/DeprecatedAttribute.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/DeprecatedAttribute.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/DeprecatedAttribute.java Wed Apr  9 07:41:59 2008
@@ -19,6 +19,9 @@
 import java.io.DataOutputStream;
 import java.io.IOException;
 
+/**
+ * Deprecated class file attribute.
+ */
 public class DeprecatedAttribute extends Attribute {
 
     private static final CPUTF8 attributeName = new CPUTF8("Deprecated", ClassConstantPool.DOMAIN_ATTRIBUTEASCIIZ);

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/EnclosingMethodAttribute.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/EnclosingMethodAttribute.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/EnclosingMethodAttribute.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/EnclosingMethodAttribute.java Wed Apr  9 07:41:59 2008
@@ -19,12 +19,15 @@
 import java.io.DataOutputStream;
 import java.io.IOException;
 
+/**
+ * Enclosing method class file attribute.
+ */
 public class EnclosingMethodAttribute extends Attribute {
 
     private int class_index;
     private int method_index;
-    private CPClass cpClass;
-    private CPNameAndType method;
+    private final CPClass cpClass;
+    private final CPNameAndType method;
     private static final CPUTF8 attributeName = new CPUTF8(
             "EnclosingMethod", ClassConstantPool.DOMAIN_ATTRIBUTEASCIIZ); //$NON-NLS-1$
 

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ExceptionTableEntry.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ExceptionTableEntry.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ExceptionTableEntry.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ExceptionTableEntry.java Wed Apr  9 07:41:59 2008
@@ -20,12 +20,15 @@
 import java.io.IOException;
 import java.util.List;
 
+/**
+ * An entry in an exception table.
+ */
 public class ExceptionTableEntry {
 
-    private int startPC;
-    private int endPC;
-    private int handlerPC;
-    private CPClass catchType;
+    private final int startPC;
+    private final int endPC;
+    private final int handlerPC;
+    private final CPClass catchType;
 
     private int startPcRenumbered;
     private int endPcRenumbered;

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ExceptionsAttribute.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ExceptionsAttribute.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ExceptionsAttribute.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/ExceptionsAttribute.java Wed Apr  9 07:41:59 2008
@@ -20,6 +20,9 @@
 import java.io.IOException;
 import java.util.Arrays;
 
+/**
+ * Exceptions class file attribute
+ */
 public class ExceptionsAttribute extends Attribute {
 
     private static final CPUTF8 attributeName = new CPUTF8(

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/InnerClassesAttribute.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/InnerClassesAttribute.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/InnerClassesAttribute.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/InnerClassesAttribute.java Wed Apr  9 07:41:59 2008
@@ -22,15 +22,14 @@
 import java.util.Iterator;
 import java.util.List;
 
-import org.apache.harmony.pack200.IcTuple;
-
-
+/**
+ * Inner classes class file attribute
+ */
 public class InnerClassesAttribute extends Attribute {
 
     private static final CPUTF8 attributeName = new CPUTF8(
             "InnerClasses", ClassConstantPool.DOMAIN_ATTRIBUTEASCIIZ); //$NON-NLS-1$
 
-
     private static class InnerClassesEntry {
         CPClass inner_class_info;
         CPClass outer_class_info;
@@ -41,13 +40,6 @@
         int inner_name_index = -1;
         int inner_class_access_flags = -1;
 
-        public InnerClassesEntry(IcTuple icTuple) {
-            this(icTuple.getC(), icTuple.getC2(), icTuple.getN(), icTuple.getF());
-        }
-
-        public InnerClassesEntry(String innerString, String outerString, String nameString, int flags) {
-
-        }
         public InnerClassesEntry(CPClass innerClass, CPClass outerClass, CPUTF8 innerName, int flags) {
             this.inner_class_info = innerClass;
             this.outer_class_info = outerClass;

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/LineNumberTableAttribute.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/LineNumberTableAttribute.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/LineNumberTableAttribute.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/LineNumberTableAttribute.java Wed Apr  9 07:41:59 2008
@@ -19,11 +19,14 @@
 import java.io.DataOutputStream;
 import java.io.IOException;
 
+/**
+ * Line number table
+ */
 public class LineNumberTableAttribute extends BCIRenumberedAttribute {
 
-    private int line_number_table_length;
-    private int[] start_pcs;
-    private int[] line_numbers;
+    private final int line_number_table_length;
+    private final int[] start_pcs;
+    private final int[] line_numbers;
     private static final CPUTF8 attributeName = new CPUTF8(
             "LineNumberTable", ClassConstantPool.DOMAIN_ATTRIBUTEASCIIZ); //$NON-NLS-1$
 

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/LocalVariableTableAttribute.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/LocalVariableTableAttribute.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/LocalVariableTableAttribute.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/LocalVariableTableAttribute.java Wed Apr  9 07:41:59 2008
@@ -23,6 +23,9 @@
 
 import org.apache.harmony.pack200.Pack200Exception;
 
+/**
+ * Local variable table
+ */
 public class LocalVariableTableAttribute extends BCIRenumberedAttribute {
 
     private int local_variable_table_length;
@@ -35,7 +38,6 @@
     private final CPUTF8[] descriptors;
     private static final CPUTF8 attributeName = new CPUTF8(
             "LocalVariableTable", ClassConstantPool.DOMAIN_ATTRIBUTEASCIIZ); //$NON-NLS-1$
-
 
     public LocalVariableTableAttribute(int local_variable_table_length,
             int[] start_pcs, int[] lengths, CPUTF8[] names,

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/LocalVariableTypeTableAttribute.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/LocalVariableTypeTableAttribute.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/LocalVariableTypeTableAttribute.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/LocalVariableTypeTableAttribute.java Wed Apr  9 07:41:59 2008
@@ -19,20 +19,21 @@
 import java.io.DataOutputStream;
 import java.io.IOException;
 
+/**
+ * Local variable type table.
+ */
 public class LocalVariableTypeTableAttribute extends Attribute {
 
-
     private int local_variable_type_table_length;
-    private int[] start_pcs;
-    private int[] lengths;
+    private final int[] start_pcs;
+    private final int[] lengths;
     private int[] name_indexes;
     private int[] signature_indexes;
-    private int[] indexes;
-    private CPUTF8[] names;
-    private CPUTF8[] signatures;
+    private final int[] indexes;
+    private final CPUTF8[] names;
+    private final CPUTF8[] signatures;
     private static final CPUTF8 attributeName = new CPUTF8(
             "LocalVariableTypeTable", ClassConstantPool.DOMAIN_ATTRIBUTEASCIIZ); //$NON-NLS-1$
-
 
     public LocalVariableTypeTableAttribute(int local_variable_type_table_length,
             int[] start_pcs, int[] lengths, CPUTF8[] names,

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/NewAttribute.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/NewAttribute.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/NewAttribute.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/NewAttribute.java Wed Apr  9 07:41:59 2008
@@ -23,12 +23,12 @@
 import java.util.List;
 
 /**
- * A New (i.e. non-predefined) Class File attribute
+ * A compressor-defined class file attribute.
  */
 public class NewAttribute extends BCIRenumberedAttribute {
 
-    private List lengths = new ArrayList(); // List of Integers
-    private List body = new ArrayList();
+    private final List lengths = new ArrayList(); // List of Integers
+    private final List body = new ArrayList();
     private ClassConstantPool pool;
 
     public NewAttribute(CPUTF8 attributeName) {
@@ -149,7 +149,7 @@
 
     private static class BCOffset extends BCValue {
 
-        private int offset;
+        private final int offset;
         private int index;
 
         public BCOffset(int offset) {
@@ -164,7 +164,7 @@
 
     private static class BCIndex extends BCValue {
 
-        private int index;
+        private final int index;
 
         public BCIndex(int index) {
             this.index = index;
@@ -173,7 +173,7 @@
 
     private static class BCLength extends BCValue {
 
-        private int length;
+        private final int length;
 
         public BCLength(int length) {
             this.length = length;

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/OperandManager.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/OperandManager.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/OperandManager.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/OperandManager.java Wed Apr  9 07:41:59 2008
@@ -21,9 +21,8 @@
 import org.apache.harmony.pack200.SegmentConstantPool;
 
 /**
- * This class keeps track of operands used. It provides
- * API to let other classes get next elements, and also
- * knows about which classes have been used recently
+ * This class keeps track of operands used. It provides API to let other classes
+ * get next elements, and also knows about which classes have been used recently
  * in super, this and new references.
  */
 public class OperandManager {

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/RuntimeVisibleorInvisibleAnnotationsAttribute.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/RuntimeVisibleorInvisibleAnnotationsAttribute.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/RuntimeVisibleorInvisibleAnnotationsAttribute.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/RuntimeVisibleorInvisibleAnnotationsAttribute.java Wed Apr  9 07:41:59 2008
@@ -19,10 +19,14 @@
 import java.io.DataOutputStream;
 import java.io.IOException;
 
+/**
+ * Annotations class file attribute, either a RuntimeVisibleAnnotations
+ * attribute or a RuntimeInvisibleAnnotations attribute.
+ */
 public class RuntimeVisibleorInvisibleAnnotationsAttribute extends AnnotationsAttribute {
 
-    private int num_annotations;
-    private Annotation[] annotations;
+    private final int num_annotations;
+    private final Annotation[] annotations;
 
     public RuntimeVisibleorInvisibleAnnotationsAttribute(CPUTF8 name, Annotation[] annotations) {
         super(name);

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/RuntimeVisibleorInvisibleParameterAnnotationsAttribute.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/RuntimeVisibleorInvisibleParameterAnnotationsAttribute.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/RuntimeVisibleorInvisibleParameterAnnotationsAttribute.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/RuntimeVisibleorInvisibleParameterAnnotationsAttribute.java Wed Apr  9 07:41:59 2008
@@ -19,10 +19,15 @@
 import java.io.DataOutputStream;
 import java.io.IOException;
 
+/**
+ * Paramenter annotations class file attribute, either a
+ * RuntimeVisibleParamenterAnnotations attribute or a
+ * RuntimeInvisibleParameterAnnotations attribute.
+ */
 public class RuntimeVisibleorInvisibleParameterAnnotationsAttribute extends AnnotationsAttribute {
 
-    private int num_parameters;
-    private ParameterAnnotation[] parameter_annotations;
+    private final int num_parameters;
+    private final ParameterAnnotation[] parameter_annotations;
 
     public RuntimeVisibleorInvisibleParameterAnnotationsAttribute(CPUTF8 name, ParameterAnnotation[] parameter_annotations) {
         super(name);
@@ -57,10 +62,13 @@
     }
 
 
+    /**
+     * ParameterAnnotation represents the annotations on a single parameter.
+     */
     public static class ParameterAnnotation {
 
-        private Annotation[] annotations;
-        private int num_annotations;
+        private final Annotation[] annotations;
+        private final int num_annotations;
 
         public ParameterAnnotation(Annotation[] annotations) {
             this.num_annotations = annotations.length;

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/SignatureAttribute.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/SignatureAttribute.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/SignatureAttribute.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/SignatureAttribute.java Wed Apr  9 07:41:59 2008
@@ -19,10 +19,13 @@
 import java.io.DataOutputStream;
 import java.io.IOException;
 
+/**
+ * Signature class file attribute
+ */
 public class SignatureAttribute extends Attribute {
 
     private int signature_index;
-    private CPUTF8 signature;
+    private final CPUTF8 signature;
 
     private static final CPUTF8 attributeName = new CPUTF8("Signature", ClassConstantPool.DOMAIN_ATTRIBUTEASCIIZ);
 

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/SourceFileAttribute.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/SourceFileAttribute.java?rev=646384&r1=646383&r2=646384&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/SourceFileAttribute.java (original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/bytecode/SourceFileAttribute.java Wed Apr  9 07:41:59 2008
@@ -19,9 +19,12 @@
 import java.io.DataOutputStream;
 import java.io.IOException;
 
+/**
+ * Source file class file attribute
+ */
 public class SourceFileAttribute extends Attribute {
 
-	private CPUTF8 name;
+	private final CPUTF8 name;
 	private int nameIndex;
     private static final CPUTF8 attributeName = new CPUTF8(
             "SourceFile", ClassConstantPool.DOMAIN_ATTRIBUTEASCIIZ); //$NON-NLS-1$



Mime
View raw message