harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjanu...@apache.org
Subject svn commit: r644661 - in /harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200: BHSDCodec.java SegmentConstantPool.java
Date Fri, 04 Apr 2008 09:48:03 GMT
Author: sjanuary
Date: Fri Apr  4 02:48:02 2008
New Revision: 644661

URL: http://svn.apache.org/viewvc?rev=644661&view=rev
Log:
Pack200 - Code tidy up

Modified:
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/BHSDCodec.java
    harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/SegmentConstantPool.java

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/BHSDCodec.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/BHSDCodec.java?rev=644661&r1=644660&r2=644661&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/BHSDCodec.java
(original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/BHSDCodec.java
Fri Apr  4 02:48:02 2008
@@ -56,9 +56,9 @@
 
     private long cardinality;
 
-    private long smallest;
+    private final long smallest;
 
-    private long largest;
+    private final long largest;
 
 	/**
 	 * Constructs an unsigned, non-delta Codec with the given B and H values.
@@ -191,10 +191,10 @@
 		return z;
 	}
 
-	private long cast32(long u) {
-        u = (long) ((long) ((u + Math.pow(2, 31)) % Math.pow(2, 32)) - Math.pow(2, 31));
-        return u;
-    }
+//	private long cast32(long u) {
+//        u = (long) ((long) ((u + Math.pow(2, 31)) % Math.pow(2, 32)) - Math.pow(2, 31));
+//        return u;
+//    }
 
     private boolean isHigh(long x) {
         return x>=l;

Modified: harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/SegmentConstantPool.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/SegmentConstantPool.java?rev=644661&r1=644660&r2=644661&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/SegmentConstantPool.java
(original)
+++ harmony/enhanced/classlib/trunk/modules/pack200/src/main/java/org/apache/harmony/pack200/SegmentConstantPool.java
Fri Apr  4 02:48:02 2008
@@ -16,8 +16,6 @@
  */
 package org.apache.harmony.pack200;
 
-import java.util.ArrayList;
-
 import org.apache.harmony.pack200.bytecode.CPFieldRef;
 import org.apache.harmony.pack200.bytecode.CPInterfaceMethodRef;
 import org.apache.harmony.pack200.bytecode.CPMethodRef;
@@ -25,10 +23,8 @@
 import org.apache.harmony.pack200.bytecode.ConstantPoolEntry;
 
 public class SegmentConstantPool {
-    /**
-     *
-     */
-    private CpBands bands;
+
+    private final CpBands bands;
 
     /**
      * @param bands



Mime
View raw message