harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexei Fedotov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-5692) [drlvm][build] remove apr-util and apr-iconv from the list of dependencies
Date Fri, 11 Apr 2008 09:54:04 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-5692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587899#action_12587899
] 

Alexei Fedotov commented on HARMONY-5692:
-----------------------------------------

Hello Alexey,
Thank you for review. I have few answer for now and will keep things updated.

   * One category enabled in a time? This is not a limitation of suggested logger: it is possible
to specify multiple -Xtrace options to enable more categories. From the other side parsing
a list of domains would cost us just a C function: this is easy to be done and quite conventional.
Disabling category is nice, and I will think about that. 
   * Generally I tried to reduce a set of logger interfaces. This applies to several of your
feature requests. The point is to create a logger good for 80% of use cases and small enough.
 For example, redirecting logging to different files can be done in a following way: first
I log all things into one file, than apply grep to separate output into different files. If
such workaround is available, there is no need to burden VM with additional functionality.

   * Why C? Java specification mandates us to use vfprintf as an end point for every output.
Imagine an applet embedded into browser which should send output to the browser console. This
means that generally C logging would have less layers. Also, there are some places in our
code where memory allocations required by C++ logging may be harmful for the process. C is
good enough for all places. DIE and WARN are pretty rare, so only the one version remains
(due to the same reason ABORT, LOG_DEBUG, LOG and many other logging calls are thrown away).
   * Why CTRACE != TRACE? Всё в имени моём. We have several problems of the following
nature  in our code: clog was included, then overwrote by cxxlog in some of later includes.
As a result, the code uses C++ logging, with clog include at the beginning. Having different
names would make people intentions more transparent.
   * Why keep C++ for TRACE and INFO? These domains are most used by programmers, and we should
be customer friendly. Those who want use C++, is allowed to do this most of the time. Also,
C++ alows nice logging for complex objects such as a managed object, or a method reference.
   * Why keep C++ for L<> localized macros. The current code is already C++ here, I
cannot rewrite anything in one patch. Generally I see that localization should be addressed
with a smaller priority to make "message numbers" speak for themselves. Generally I believe
we should just use portlib instead of writing things ourselves, but not now.


> [drlvm][build] remove apr-util and apr-iconv from the list of dependencies 
> ---------------------------------------------------------------------------
>
>                 Key: HARMONY-5692
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5692
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Alexei Fedotov
>         Attachments: logger.1.patch, logger.patch
>
>
> Two optional apr modules (apr-util and apr-iconv) modules are not used by DRLVM. Removing
them speeds up a build process.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message