harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Cornwall (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HARMONY-5677) [classlib][pack200] Removed unnecessary sort code
Date Tue, 01 Apr 2008 21:55:24 GMT

     [ https://issues.apache.org/jira/browse/HARMONY-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrew Cornwall updated HARMONY-5677:
-------------------------------------

    Attachment: test.patch
                main.patch

main.patch contains code changes, including deleting all comparisonStrings and their caches
as well as ClassPoolSet.

test.patch includes a few updates to reflect the fact that comparisonString has been deleted
and ClassConstantPool.resolve has been reworked.


> [classlib][pack200] Removed unnecessary sort code
> -------------------------------------------------
>
>                 Key: HARMONY-5677
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5677
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>         Environment: All Pack200
>            Reporter: Andrew Cornwall
>         Attachments: main.patch, test.patch
>
>
> The class pool code went through a number of sorts in order to approximate (not very
well) the sort order of the Sun pack200 code. Unless the two are identical, this isn't necessary,
and just bloats the code as well as slows it down. 
> This patch (and it's a big one) removes the unnecessary sorting. It deletes the class
ClassPoolSet and a number of methods under the ClassFileEntry hierarchy. In fact, these changes
may make it easier to get identical sorting, although that's not what this patch does.
> The patch improves performance by about another 25%.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message