harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sian January (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (HARMONY-5678) [classlib][pack200] LocalVariableTableAttribute contains System.out.println
Date Wed, 02 Apr 2008 10:40:24 GMT

     [ https://issues.apache.org/jira/browse/HARMONY-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sian January resolved HARMONY-5678.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 5.0M6

I think this was your code but I've fixed it anyway as there's not much point submitting a
patch for something this small :)

Fixed at r643825 - please confirm that this resolves the issue.

> [classlib][pack200] LocalVariableTableAttribute contains System.out.println
> ---------------------------------------------------------------------------
>
>                 Key: HARMONY-5678
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5678
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: All pack200
>            Reporter: Andrew Cornwall
>            Priority: Minor
>             Fix For: 5.0M6
>
>
> The implementation of renumber(List bytecodeOffsets) in LocalVariableTableAttribute contains
the following code:
>             // First get the index of the start_pc in the byteCodeOffsets
>             int indexOfStartPC = unrenumbered_start_pcs[index];
>             // Given the index of the start_pc, we can now add
>             // the encodedLength to it to get the stop index.
>             int stopIndex = indexOfStartPC + encodedLength;
>             if(stopIndex < 0) {
>                 System.out.println(stopIndex);
>             }
> I suspect we can get rid of the System.out.println and throw an Error or some other action.
I don't remember if I added this code or not, so I'm loath to delete it without asking.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message