harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexei Fedotov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-5679) [classlib][archive] UTF-8 decoder & Attributes.Name.hashCode optimizations
Date Thu, 03 Apr 2008 08:48:24 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-5679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585014#action_12585014

Alexei Fedotov commented on HARMONY-5679:

Tim, thanks!

Besides <ctrl>+F in Eclipse a regression test targets CharacterDecoderTest and its extensions.

1. Several testcases worked with a given ByteBuffer in now were cloned into in.asReadOnlyBuffer().
2. UTF decoder test was supplemented with long UTF chars, a size of one buffer adjusted to
a longer value
3. unibytes, unistr fields were replaced with getter functions which are easier to override
4. lowercased "booleanTrue"/"booleanFalse" were replaced with capitalized sensible "" / "IncompleteBuffer"
in test case names

> [classlib][archive] UTF-8 decoder & Attributes.Name.hashCode optimizations
> --------------------------------------------------------------------------
>                 Key: HARMONY-5679
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5679
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>            Reporter: Alexei Fedotov
>            Assignee: Tim Ellison
>         Attachments: attr_name_hash.patch, utf8_decode.patch, utf8_decode_pos.patch,
utf8_decode_review.patch, utf8_decode_test.patch
> Found a bug in UTF-8 patch. pos++ is not incremented on fast path. Seems we don't have
a test for this.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message