Return-Path: 
 <commits-return-52484-apmail-harmony-commits-archive=harmony.apache.org@harmony.apache.org>
Delivered-To: apmail-harmony-commits-archive@www.apache.org
Received: (qmail 95822 invoked from network); 27 Mar 2008 15:37:40 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 27 Mar 2008 15:37:40 -0000
Received: (qmail 56432 invoked by uid 500); 27 Mar 2008 15:37:38 -0000
Delivered-To: apmail-harmony-commits-archive@harmony.apache.org
Received: (qmail 56406 invoked by uid 500); 27 Mar 2008 15:37:38 -0000
Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@harmony.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@harmony.apache.org>
List-Post: <mailto:commits@harmony.apache.org>
List-Id: <commits.harmony.apache.org>
Reply-To: dev@harmony.apache.org
Delivered-To: mailing list commits@harmony.apache.org
Received: (qmail 56384 invoked by uid 99); 27 Mar 2008 15:37:38 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Mar 2008 08:37:38 -0700
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Mar 2008 15:36:56 +0000
Received: from brutus (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id 5A0CF234C0C3
	for <commits@harmony.apache.org>; Thu, 27 Mar 2008 08:35:25 -0700 (PDT)
Message-ID: <2067047987.1206632125367.JavaMail.jira@brutus>
Date: Thu, 27 Mar 2008 08:35:25 -0700 (PDT)
From: "Sian January (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Assigned: (HARMONY-5654) [classlib][pack200] Init methods
 cannot be synchronized
In-Reply-To: <736916229.1206554378631.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org


     [ https://issues.apache.org/jira/browse/HARMONY-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sian January reassigned HARMONY-5654:
-------------------------------------

    Assignee: Sian January

> [classlib][pack200] Init methods cannot be synchronized
> -------------------------------------------------------
>
>                 Key: HARMONY-5654
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5654
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: All pack200
>            Reporter: Andrew Cornwall
>            Assignee: Sian January
>         Attachments: pack200.pack.gz
>
>
> In the current code, it's possible for a CPMethod  <init> to be emitted as synchronized. This will not pass Sun's verification. For instance, if you run pack200 on itself, NewAttributeBands$LayoutElement in the following will be emitted with a synchronized <init>.
> I've temporarily hacked this with the following code in CPMethod:
> 	public CPMethod(CPUTF8 name, CPUTF8 descriptor, long flags, List attributes) {
> 		// TODO Check that we only pass these on, or remap
>         super(name, descriptor, 0x7FFF & flags, attributes);
> 	    if(name.underlyingString().equals("<init>")) {
> 	        // hack hack - init should never be synchronized
> 	        SegmentUtils.debug("Hacking off synchronized on an init method");
> 	        this.flags = (short)(this.flags & 0x7FDF);
> 	    }
> 	}
> but I really need to look into it more deeply and find out why the 0x20 flag is being passed in. (This may end up being an encoding issue, but I need to look more first).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.