Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <1864945970.1206630204330.JavaMail.jira@brutus>
Date: Thu, 27 Mar 2008 08:03:24 -0700 (PDT)
From: "Aleksey Shipilev (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Commented: (HARMONY-5635) [classlib][luni][performance]
 ObjectInputStream should empty the underlying stream in right way
In-Reply-To: <243597206.1206303684510.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HARMONY-5635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582675#action_12582675 ] 

Aleksey Shipilev commented on HARMONY-5635:
-------------------------------------------

Thanks, Tim!
Sorry for (1), it was my oversight. You're right.

> [classlib][luni][performance] ObjectInputStream should empty the underlying stream in right way
> -----------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5635
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5635
>             Project: Harmony
>          Issue Type: Improvement
>            Reporter: Aleksey Shipilev
>            Assignee: Tim Ellison
>         Attachments: 0003-serial-emptystream.patch
>
>
> For now, ObjectInputStream empties the underlying stream by assigning it to static emptyStream instance.
> This is very buggy way to do things, for two reasons:
>  1. Consider you've done
>          ByteArrayInputStream temp1 = emptyStream;
>      then you might do temp1.write(...) and spoil the emptyStream with garbage. Luckily there are no such opportunities in current OIS.
>  2. Consider you've "emptied" several streams in different threads and then ask for OIS.available() then you would have the BAIS.available() [synchronized by spec] - and the _contention_, up to fat monitors invocation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.