harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Ellison (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (HARMONY-5634) [classlib][luni][performance] ObjectInputStream should use HashMap instead of Hashtable for internal storage
Date Thu, 27 Mar 2008 15:05:25 GMT

     [ https://issues.apache.org/jira/browse/HARMONY-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Tim Ellison resolved HARMONY-5634.
----------------------------------

    Resolution: Fixed

Thanks Aleksey.

Patch applied to LUNI module at repo revision r641841.
Please check it was applied as you expected.

I didn't make it an unmodifiable collection since it is already a private field, and I'd have
to add a field to load the primitives before wrappering it etc.  In this case the extra wrapper
seems unnecessary.


> [classlib][luni][performance] ObjectInputStream should use HashMap instead of Hashtable
for internal storage
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5634
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5634
>             Project: Harmony
>          Issue Type: Improvement
>            Reporter: Aleksey Shipilev
>            Assignee: Tim Ellison
>         Attachments: 0002-serial-HashMap.patch
>
>
> For now, ObjectInputStream uses Hashtable for two storages:
>  1. static PRIMITIVE_CLASSES, populated via static initializer, read by all instances
(e.g. in theory by all threads)
>  2. private objectsRead, serving as instance-local buffer
> Both of these storages should be migrated to HashMap, since Hashtable.get is synchronized
and synchronization is not needed here.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message