harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Ellison (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-5517) [classlib][archive] simplifying archive code by fixing manifest encoding to UTF-8
Date Thu, 13 Mar 2008 14:56:24 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-5517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12578321#action_12578321
] 

Tim Ellison commented on HARMONY-5517:
--------------------------------------

It's only a minor style change.  In this case there is only one user of this variable, and
the name ENCODING is less descriptive than the constant value it contains, so I felt it is
better to use the value directly.

I would have used a final variable if the value had been used in a number of places (and therefore
you wanted to show it is required to be the same everywhere it is used), or if the value was
'magic' so the variable was descriptive (e.g. BYTE_ORDER_MARK = "EF BB BF").

Regards,
Tim


> [classlib][archive] simplifying archive code by fixing manifest encoding to UTF-8
> ---------------------------------------------------------------------------------
>
>                 Key: HARMONY-5517
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5517
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Alexei Fedotov
>            Assignee: Tim Ellison
>             Fix For: 5.0M6
>
>         Attachments: remove_manifest_encoding.patch, remove_manifest_encoding_2.patch,
remove_manifest_encoding_3.patch
>
>
> By specification [1] manifests are encoded in UTF-8. There is no need to make code more
complex than that, so legacy of HARMONY-14 may be removed. Testing the patch.
> [1] http://java.sun.com/javase/6/docs/technotes/guides/jar/jar.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message