harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sian January (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-5594) [classlib][pack200] Deprecated classes don't have Deprecated attribute
Date Wed, 12 Mar 2008 13:36:46 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577844#action_12577844

Sian January commented on HARMONY-5594:

Hi Andrew,

The patch looks fine, except that I'm just wondering why you didn't use instanceof on line
156 of Segment?  so:

> [classlib][pack200] Deprecated classes don't have Deprecated attribute
> ----------------------------------------------------------------------
>                 Key: HARMONY-5594
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5594
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: Pack200 HEAD
>            Reporter: Andrew Cornwall
>            Assignee: Sian January
>         Attachments: main.patch
> Classes which are marked as Deprecated do not get the Deprecated attribute when they're
written out. In fact, it appears that any "undefined" attribute won't be written out.
> This patch causes all attributes stored with a class to be written out into its class
file except for SourceFileAttribute, which is recomputed right before it is written.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message