Return-Path: Delivered-To: apmail-harmony-commits-archive@www.apache.org Received: (qmail 90553 invoked from network); 4 Feb 2008 23:59:31 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 4 Feb 2008 23:59:31 -0000 Received: (qmail 53903 invoked by uid 500); 4 Feb 2008 23:59:23 -0000 Delivered-To: apmail-harmony-commits-archive@harmony.apache.org Received: (qmail 53885 invoked by uid 500); 4 Feb 2008 23:59:23 -0000 Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list commits@harmony.apache.org Received: (qmail 53876 invoked by uid 99); 4 Feb 2008 23:59:22 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Feb 2008 15:59:22 -0800 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Feb 2008 23:59:15 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 1CC00714071 for ; Mon, 4 Feb 2008 15:59:08 -0800 (PST) Message-ID: <23194380.1202169548115.JavaMail.jira@brutus> Date: Mon, 4 Feb 2008 15:59:08 -0800 (PST) From: "Andrew Cornwall (JIRA)" To: commits@harmony.apache.org Subject: [jira] Updated: (HARMONY-5456) [pack200][classlib] innerclass handling and invokespecial_new_init In-Reply-To: <22974285.1202169427851.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HARMONY-5456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Cornwall updated HARMONY-5456: ------------------------------------- Attachment: test.patch main.patch Code changes in main.patch; test case changes in test.patch. > [pack200][classlib] innerclass handling and invokespecial_new_init > ------------------------------------------------------------------ > > Key: HARMONY-5456 > URL: https://issues.apache.org/jira/browse/HARMONY-5456 > Project: Harmony > Issue Type: Bug > Components: Classlib > Environment: All Pack200 > Reporter: Andrew Cornwall > Attachments: main.patch, test.patch > > > This patch does a number of things > - fixes inner class filename handling (so inner class Foo$1 has SourceFileAttribute Foo) > - computes inner classes correctly (ic_stored) > - removes redundant variables from CPMethodRef > - adds additional necessary resolution after resorting the class pools > - fixes a bug where anewarray or multianewarray instructions could cause invalid class refs for subsequent invokespecial_new_init instructions in the same method > - cleaned up the code a little > It looks as if Sian and I stepped on each others' code when modifying Segment, so please pay special attention to that class in case I accidentally overwrote some of her changes. > I've also re-added the SQL and JNDI tests to the test suite. Yes, they take extra time - but it was the JNDI tests which tickled the invokespecial_new_init bug that's fixed in this patch. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.