Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <19688046.1202902448889.JavaMail.jira@brutus>
Date: Wed, 13 Feb 2008 03:34:08 -0800 (PST)
From: "Aleksey Shipilev (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Commented: (HARMONY-5396) [drlvm][em] excess ValueProfiler
 locking causes degradation on JITted code with profiling
In-Reply-To: <33481235.1200494074776.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HARMONY-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568516#action_12568516 ] 

Aleksey Shipilev commented on HARMONY-5396:
-------------------------------------------

Egor,

1. Thanks, all is OK after r627320.

2. Whoops, I thought I've eliminated them, sorry. Will teach CDT further :)

3. Yes, you're right on atomic increment approach for this counter - that's an option too. I've messed up things a little.

4. Let's implement the (3) option and then measure performance of benchmarks for all bulk.

5. I agree with Pavel, updateStrategy should be propagated to TNV_DIVIDED too.

Thanks,
Aleksey.


> [drlvm][em] excess ValueProfiler locking causes degradation on JITted code with profiling
> -----------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5396
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5396
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Aleksey Shipilev
>            Assignee: Egor Pasko
>         Attachments: 0001-ValueProfileCollector-refactoring-to-separate-FirstN-and-Divided-methods.txt, 0002-value-profiling-options-locked-flagged_all-flagged_insert-unsafe.txt, 0002-ValueProfileCollector-implementing-locking-strategies.txt, 0003-value-profiling-options-locked-flagged_all-flagged_insert-unsafe.txt, 0004-value-profiling-reviving-locked-profile.txt, HARMONY-5396-syncTie.patch
>
>
> During investigation of serious slowdown in some microbenchmark, excess locking in ValueProfiler was identified. 
> Please see Harmony-dev thread for the details: http://markmail.org/message/tatsfbyb7eb3q3rr

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.