Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <1557712708.1204047051506.JavaMail.jira@brutus>
Date: Tue, 26 Feb 2008 09:30:51 -0800 (PST)
From: "Alexei Fedotov (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Commented: (HARMONY-5473) [classlib][archive] Manifest file
 with empty line proves IOException
In-Reply-To: <20291604.1202404748695.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HARMONY-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572569#action_12572569 ] 

Alexei Fedotov commented on HARMONY-5473:
-----------------------------------------

Stepan, theoretically your understanding may be correct as well. Personally I prefer to delay all verifications, etc to get a startup speed up. From the other side it looks like we have compatibility tests which show IOException on RI in case of incorrect line breaks (probably because they probably are using BufferedInputStream for reading of line break separated stream). Without a good reason we'd better be compatible. 

> [classlib][archive] Manifest file with empty line proves IOException
> --------------------------------------------------------------------
>
>                 Key: HARMONY-5473
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5473
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Evgeniya Maenkova
>            Assignee: Alexey Petrenko
>            Priority: Critical
>         Attachments: archive.patch, archive.patch, hyts_manifest1.mf, MANIFEST.MF, MANIFEST2.MF
>
>
> I cannot start some of my apps, because their jar-files contain manifests with empty lines, proving IOException on Harmony.
> The situation can be reproduced by manifest file  with empty line creation and invoking new Manifest(InputStream). Manifest files which proves this will be attached.
> Test case output:
> $ /cygdrive/c/Harmony_to_run/trunk/working_vm/build/win_ia32_msvc_release/deploy/jdk/jre/bin/java  Test MANIFEST2.MF
> Uncaught exception in main:
> java.io.IOException: Invalid attribute
>         at java.util.jar.InitManifest.addAttribute(InitManifest.java:282)
>         at java.util.jar.InitManifest.<init>(InitManifest.java:71)
>         at java.util.jar.Manifest.read(Manifest.java:173)
>         at java.util.jar.Manifest.<init>(Manifest.java:76)
>         at Test.main(Test.java:8)
> $ /cygdrive/w/UBS/Builds/jdk1.6.0_win32/bin/java Test MANIFEST2.MF
> end
> Test case is:
> import java.io.FileInputStream;
> import java.util.jar.Manifest;
> public class Test {
>     public static void main(String[] args) throws Exception {
> 		String fileName = args[0];
> 		FileInputStream fs = new FileInputStream(fileName);
>         Manifest m = new Manifest(fs);   		
> 		fs.close();		
> 		System.out.println("end");
> 	}
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.