Return-Path: Delivered-To: apmail-harmony-commits-archive@www.apache.org Received: (qmail 64291 invoked from network); 12 Feb 2008 16:15:30 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 12 Feb 2008 16:15:30 -0000 Received: (qmail 33628 invoked by uid 500); 12 Feb 2008 16:15:24 -0000 Delivered-To: apmail-harmony-commits-archive@harmony.apache.org Received: (qmail 33603 invoked by uid 500); 12 Feb 2008 16:15:23 -0000 Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list commits@harmony.apache.org Received: (qmail 33594 invoked by uid 99); 12 Feb 2008 16:15:23 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Feb 2008 08:15:23 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Feb 2008 16:15:01 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 78FD571407F for ; Tue, 12 Feb 2008 08:15:09 -0800 (PST) Message-ID: <1417141.1202832909493.JavaMail.jira@brutus> Date: Tue, 12 Feb 2008 08:15:09 -0800 (PST) From: "Andrew Cornwall (JIRA)" To: commits@harmony.apache.org Subject: [jira] Updated: (HARMONY-5489) [pack200][classlib] java.util.ZipException("No Entries") on unpack close() In-Reply-To: <9586287.1202777588427.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HARMONY-5489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Cornwall updated HARMONY-5489: ------------------------------------- Summary: [pack200][classlib] java.util.ZipException("No Entries") on unpack close() (was: [pack200][classlib] ClassBands.getCodeHandlerClassRCN() sometimes contains nulls?) Using Archive.unpack(), the same test case throws: Thread [main] (Suspended (exception ZipException)) JarOutputStream(ZipOutputStream).finish() line: 159 JarOutputStream(ZipOutputStream).close() line: 59 Archive.unpack() line: 153 TestUnpack.main(String[]) line: 15 > [pack200][classlib] java.util.ZipException("No Entries") on unpack close() > -------------------------------------------------------------------------- > > Key: HARMONY-5489 > URL: https://issues.apache.org/jira/browse/HARMONY-5489 > Project: Harmony > Issue Type: Bug > Components: Classlib > Environment: All Pack200 > Reporter: Andrew Cornwall > Assignee: Sian January > Attachments: mypack.pack > > > The ClassBands.getCodeHandlerClassRCN() method answers an array of arrays of Strings (which is stored as handlerClassTypes in BcBands.unpack). That structure sometimes contains what appear to be inappropriate nulls, which leads to the following code failing: > (from BcBands.unpack()): > if(handlerCount != null) { > for (int j = 0; j < handlerCount[i]; j++) { > String handlerClass = handlerClassTypes[i][j]; > CPClass cpHandlerClass = new CPClass(handlerClass); > ExceptionTableEntry entry = new ExceptionTableEntry( > handlerStartPCs[i][j], handlerEndPCs[i][j], > handlerCatchPCs[i][j], cpHandlerClass); > exceptionTable.add(entry); > } > handlerClassTypes[i][j] can be null, which means that handlerClass is null. The code then fails when trying to create a new CPClass(null). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.