harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Egor Pasko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-5396) [drlvm][em] excess ValueProfiler locking causes degradation on JITted code with profiling
Date Wed, 13 Feb 2008 15:33:09 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568587#action_12568587
] 

Egor Pasko commented on HARMONY-5396:
-------------------------------------

4. I think we cannot commit (3) before M5 due to the in-progress state of the feature freeze
:) (agreed with Pavel, all modes are interesting)

5. Pavel I just tried to apply the same logic to TNV_DIVIDED as you applied for LOCKED, FLAGGED,
etc. (i.e. from your words "My understanding on the dev list was that we experiment with the
startegies and choose 1-2 best to commit"), looks like I misunderstood that TNV_DIVIDED is
the "2" in "1-2 best" :)

propagating updateStrategy to TNV_DIVIDED seems like not so trivial, I did not think about
it yet. IMHO, it makes sense to check TNV_DIVIDED on a server benchmark (server_aggressive
mode) first, and if id gives no benefit, drop the idea of improving updateStrategy  as redundant
for a while.

I am not in a hurry, we can first implement (3.c) then check all the stuff we have. Sounds
good?

> [drlvm][em] excess ValueProfiler locking causes degradation on JITted code with profiling
> -----------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5396
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5396
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Aleksey Shipilev
>            Assignee: Egor Pasko
>         Attachments: 0001-ValueProfileCollector-refactoring-to-separate-FirstN-and-Divided-methods.txt,
0002-value-profiling-options-locked-flagged_all-flagged_insert-unsafe.txt, 0002-ValueProfileCollector-implementing-locking-strategies.txt,
0003-value-profiling-options-locked-flagged_all-flagged_insert-unsafe.txt, 0004-value-profiling-reviving-locked-profile.txt,
HARMONY-5396-syncTie.patch
>
>
> During investigation of serious slowdown in some microbenchmark, excess locking in ValueProfiler
was identified. 
> Please see Harmony-dev thread for the details: http://markmail.org/message/tatsfbyb7eb3q3rr

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message