harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ilya Berezhniuk (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-5490) [drlvm][signals] New heuristics for crash handler
Date Wed, 13 Feb 2008 06:38:08 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-5490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568445#action_12568445
] 

Ilya Berezhniuk commented on HARMONY-5490:
------------------------------------------

I think these asserts were used for debugging the decoder itself, and only JITted code was
parsed.
Now decoder is stable, and decoder is used for parsing native code.

When decoding native code from a native compiler, error code should be returned instead of
assertion - native code can include unknown constructs, or even wrong/corrupted instructions.
This is the case in current native stack unwinding algorithm: when looking for return address
in stack, it tries to decode CALL instruction with several offsets behind the return address.


> [drlvm][signals] New heuristics for crash handler
> -------------------------------------------------
>
>                 Key: HARMONY-5490
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5490
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Ilya Berezhniuk
>            Assignee: Gregory Shimansky
>         Attachments: ch_proto_38.patch, lnx_x86_64_debug.txt, lnx_x86_debug.txt, win_x86_64_debug.txt,
win_x86_debug.txt
>
>
> Suggested patch implements new heuristic algorithm for native stack unwinding.
> This algorithm enables quite correct stack printing for x86_64 platform.
> Internal crash handler interfaces are simplified and improved.
> There is a problem with line information on Windows x86_64 - I'll try to solve this in
separate JIRA.
> All pre-commit tests are passed for me on 4 platforms.
> Crash stack examples are attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message