harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Egor Pasko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-5396) [drlvm][em] excess ValueProfiler locking causes degradation on JITted code with profiling
Date Wed, 13 Feb 2008 09:34:08 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568476#action_12568476
] 

Egor Pasko commented on HARMONY-5396:
-------------------------------------

Aleksey, Pavel

1. 0004-value-profiling-reviving-locked-profile.txt  applied at r627320, please, check

2. Alexey, plz, do not put tabs and trailing spaces into code :)

3. for atomic increment there is approach (c) that I am suggesting -- just use the userspace
atomic increment x86 instruction, atomicity is guaranteed by hardware, fast and furious (surprise,
surprise:)

4. Now server_aggressive is in place, back to my question: is there any difference between
LOCKED and LOCKED_INSERT on your benchmark(s)?

5. we also have vpalgo=TNV_DIVIDED (which should be an even better profile if implemented
right), did you try it on server_aggressive? if it makes no effect, then. according to Pavel's
strategy we should remove it. In my strategy, I would not, because some day processors may
change and this algorithm may be of use (and even now, I do not know, what happens on mobile
processors)

thanks for discussions

> [drlvm][em] excess ValueProfiler locking causes degradation on JITted code with profiling
> -----------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5396
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5396
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Aleksey Shipilev
>            Assignee: Egor Pasko
>         Attachments: 0001-ValueProfileCollector-refactoring-to-separate-FirstN-and-Divided-methods.txt,
0002-value-profiling-options-locked-flagged_all-flagged_insert-unsafe.txt, 0002-ValueProfileCollector-implementing-locking-strategies.txt,
0003-value-profiling-options-locked-flagged_all-flagged_insert-unsafe.txt, 0004-value-profiling-reviving-locked-profile.txt,
HARMONY-5396-syncTie.patch
>
>
> During investigation of serious slowdown in some microbenchmark, excess locking in ValueProfiler
was identified. 
> Please see Harmony-dev thread for the details: http://markmail.org/message/tatsfbyb7eb3q3rr

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message