harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexei Fedotov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-5526) [classlib][archive] removing double entry reads
Date Fri, 29 Feb 2008 00:53:53 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-5526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573536#action_12573536
] 

Alexei Fedotov commented on HARMONY-5526:
-----------------------------------------

Vladimir, I'm currently looking into the patch. Could you please clarify two questions?

* The user may create an entry via new ZipEntry (name) constructor. In this case all parameters
passed to Java_java_util_zip_ZipFile_inflateEntryImpl2 seem to be undefined. Is it ok? THe
only thing which comes into my mind is adding the following guard right before inflateEntryImpl2
call.

        if (entry.size == -1 || entry.compressedSize == -1 || entry.compressionMethod == -1)
{ // uninitialized
            entry = getEntry(entry.getName());
        }

* In addition to java parameters ZipEntry in C contains more pointers. zip_initZipEntry initializes
all this data with zeros. Are these pointers safe to be left as is? I'm getting crashes somehow.

> [classlib][archive] removing double entry reads
> -----------------------------------------------
>
>                 Key: HARMONY-5526
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5526
>             Project: Harmony
>          Issue Type: Sub-task
>            Reporter: Alexei Fedotov
>         Attachments: zip_diff.diff
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message