[ https://issues.apache.org/jira/browse/HARMONY-5456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tim Ellison resolved HARMONY-5456.
----------------------------------
Resolution: Fixed
Thanks Andrew.
Patch applied to PACK200 module at repo revision r618613.
Please check it was applied as you expected.
> [pack200][classlib] innerclass handling and invokespecial_new_init
> ------------------------------------------------------------------
>
> Key: HARMONY-5456
> URL: https://issues.apache.org/jira/browse/HARMONY-5456
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: All Pack200
> Reporter: Andrew Cornwall
> Assignee: Tim Ellison
> Attachments: main.patch, test.patch
>
>
> This patch does a number of things
> - fixes inner class filename handling (so inner class Foo$1 has SourceFileAttribute
Foo)
> - computes inner classes correctly (ic_stored)
> - removes redundant variables from CPMethodRef
> - adds additional necessary resolution after resorting the class pools
> - fixes a bug where anewarray or multianewarray instructions could cause invalid class
refs for subsequent invokespecial_new_init instructions in the same method
> - cleaned up the code a little
> It looks as if Sian and I stepped on each others' code when modifying Segment, so please
pay special attention to that class in case I accidentally overwrote some of her changes.
> I've also re-added the SQL and JNDI tests to the test suite. Yes, they take extra time
- but it was the JNDI tests which tickled the invokespecial_new_init bug that's fixed in this
patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
|