harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Hindess (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-5446) [classlib][luni][java6] Arrays.binarySearch(Object[],Object) will throw ClassCastException while RI won't
Date Thu, 31 Jan 2008 09:31:36 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-5446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564346#action_12564346
] 

Mark Hindess commented on HARMONY-5446:
---------------------------------------

Please don't apply this patch.  See my previous comment.

It is identical to the patch for HARMONY-5443 that is already committed in the java5 trunk
and will in due course be merged.  Since the patch contains the same error as the patch for
HARMONY-5443 - fixed by Stepan in commit r616721 - applying the patch will actually cause
conflicts during a subsequent merge.

If there is some reason this is urgent, then do the trunk to branch merge instead.


> [classlib][luni][java6] Arrays.binarySearch(Object[],Object) will throw ClassCastException
while RI won't
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5446
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5446
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Sean Qiu
>            Assignee: Tony Wu
>         Attachments: Harmony-5446.diff
>
>
> Harmony's Arrays.binarySearch(Object[],Object o) will throw ClassCastException when second
parameter does not implement Comparable interface.
> It means that RI will call compareTo from the first parameter rather than the second
parameter.
> Here is the test case
> ---------------------------------
> public class MethodTest extends TestCase {
> public void testMethod() throws Exception{
> Object object = new Object();
> Object[] objects = new MockComparable[] { new MockComparable() };
> assertEquals("Should always return 0", 0, Arrays.binarySearch(objects, object));
> }
> static class MockComparable implements Comparable{
> public int compareTo(Object o) {
> return 0;
> }
> }
> }
> ------------------------------
> Result:
> RI passed
> Harmony failed
> ------------------------------
> Java 5 relate: HARMONY-5443

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message