[ https://issues.apache.org/jira/browse/HARMONY-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558324#action_12558324
]
Ilya Berezhniuk commented on HARMONY-5379:
------------------------------------------
Pavel, thanks for the notes!
1) I think it's not feasible to use the define in platform-specific code where width and modifiers
are known. Using the define in *printf format string requires splitting the format string,
so I don't like to use this when I can avoid this.
2) I'll try to modify locking sequence in sd_print_stack() to be sure that initialization
is serialized (I think it's reasonable to acquire hythread_global_lock before calling sd_initialize).
I'll update the patch soon.
> [drlvm][signals] Several crash handler improvements
> ---------------------------------------------------
>
> Key: HARMONY-5379
> URL: https://issues.apache.org/jira/browse/HARMONY-5379
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Environment: All
> Reporter: Ilya Berezhniuk
> Attachments: H-5379.patch, H-5379.patch
>
>
> Together with unifying signal handlers in HARMONY-5366, I've made some improvements in
crash handler.
> The patch is in attachment.
> Following features were added:
> - when one thread is in crash handler, other threads are blocked to prevent from printing
several stack traces
> - processor registers are now printed on Linux also
> - analysis of crashed address:
> - a module containing crashed address is identified
> - detected module kind: VM module / JNI library / other
> - if crash address does not belong to any module, containing memory region is identified;
access information is provided
> - the whole table of loaded modules is printed
> - the list of threads registeret to VM is printed with crashed thread marked
> - heap usage in crash handler was reduced to be sure that at least some kind of info
will be printed (if global heap lock is not released)
> I'm also working on some new heuristics to improve native stack unwinding on x86_64,
but this work is not finished yet, so I'll prove it in additional patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
|