harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pavel Pervov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-5277) [startup][performance] general optimizations
Date Mon, 10 Dec 2007 08:18:43 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549964
] 

Pavel Pervov commented on HARMONY-5277:
---------------------------------------

Natalya,

I've reviewed classloading.patch and have the following observations.
1) The nature of all three collections (fields, methods, reflected methods) is the same. So,
they are good candidates for code reuse.
2) It is certainly a misprint. Please, replace 'findMachingMethod' with 'findMatchingMethod'
(missed 't' in 'matching').
3) In reflection_findMatching*Method results of many operations are not checked. Parameters
are not checked either.
4) Well, startup performance may increase as the result of this patch but what will happen
with runtime performance? The patch removes reflection data cache and introduces M2N on each
call to reflection. I don't think this will add to performance.
5) Missed space in exception constructor in j.l.Class.getMethod - ("No such method" + methodName).
6) Why changing class_lookup_method_recursive?

More to come...

> [startup][performance] general optimizations
> --------------------------------------------
>
>                 Key: HARMONY-5277
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5277
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Naumova Natalya 
>         Attachments: classloading.patch, jarmapping.BCP.patch, uncompressed_BCP_jars.classlib.patch,
uncompressed_BCP_jars.vm.patch
>
>
> Some general improvements for VM startup will be collected here. Optimizations are for
both DRLVM and CLASSLIB. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message