harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pavel Pervov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-5277) [startup][performance] general optimizations
Date Mon, 10 Dec 2007 09:11:43 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549978
] 

Pavel Pervov commented on HARMONY-5277:
---------------------------------------

Now to jarmapping.BCP.patch.

1) It would be great to add memory mapping functionality to port (if it is missing there)
rather then adding platform dependent code to currently platform independent code.
2) 'cd_size = fsize < 67000 ? fsize : 67000' is done twice.
3) we should strive to keep formatting changes separate from code changes. This reduces review
alot.
4) Why changing 'base + offset' to '&base[offset]'?
5) The same with 'printf's in this patch.


> [startup][performance] general optimizations
> --------------------------------------------
>
>                 Key: HARMONY-5277
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5277
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Naumova Natalya 
>         Attachments: classloading.patch, jarmapping.BCP.patch, uncompressed_BCP_jars.classlib.patch,
uncompressed_BCP_jars.vm.patch
>
>
> Some general improvements for VM startup will be collected here. Optimizations are for
both DRLVM and CLASSLIB. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message