harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sian January (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-5289) [pack200][classlib] Added code to support tableswitch/lookupswitch
Date Wed, 12 Dec 2007 10:25:43 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-5289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550904
] 

Sian January commented on HARMONY-5289:
---------------------------------------

Andrew - with tableswitch I would expect there to be one case value - the initial one.  Then
with lookupswitch I would expect case_count case values.  So using your test case (pasted
below) I get one value of 97 in BcBands.bcCaseValue, which I think should be correct.  I noticed
in your code above you're printing out the value before you actually assign it, so it would
always be 0 in the println.  Can you swap lines 4 and 5 (above) around and see what happens?


Test case:

public class SimpleHelloWorld {
    public static void main(String[] args) {
        switch (args[0].charAt(0)) {
            case 'a': {
                System.out.println("A");
            }
            case 'b': {
                System.out.println("B");
            }
            case 'c': {
                System.out.println("C");
            }
            default: {
                System.out.println("Default");
            }
        }
    }
}

> [pack200][classlib] Added code to support tableswitch/lookupswitch
> ------------------------------------------------------------------
>
>                 Key: HARMONY-5289
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5289
>             Project: Harmony
>          Issue Type: New Feature
>          Components: Classlib
>         Environment: All Pack200
>            Reporter: Andrew Cornwall
>            Priority: Minor
>         Attachments: BcBands.java.patch, BcBandsTest.java.patch, main.patch, test.patch
>
>
> I have added some code to support the lookupswitch and tableswitch bytecodes. This code
is currently turned off (there's a boolean in SwitchForm) but can be enabled as soon as BcBands
is calculating case_values correctly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message