Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <14376019.1194520670630.JavaMail.jira@brutus>
Date: Thu, 8 Nov 2007 03:17:50 -0800 (PST)
From: "Alexey Varlamov (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Commented: (HARMONY-4621) [drlvm][jit] Stack misalignment
 when using SSE instructions
In-Reply-To: <4182933.1186924423470.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HARMONY-4621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541026 ] 

Alexey Varlamov commented on HARMONY-4621:
------------------------------------------

Oh, another king-size patch. Generally looks good, I only spotted mistyped define in jit_runtime_support_common.h:
#define STACK_ALIGN4         (0x00000008)
BTW, related defines are duplicated thrice, in both JITs and in VM stubs. Moreover, seems there appears conceptual binding, i.e. alignment should be coherent in VM and JIT. Indeed this may worth explicit and more articulated interface, need to think about this?


> [drlvm][jit] Stack misalignment when using SSE instructions
> -----------------------------------------------------------
>
>                 Key: HARMONY-4621
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4621
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Naumova Natalya 
>            Assignee: Alexey Varlamov
>         Attachments: stackalign_part1.patch
>
>
> This issue is related with stack misalignment: data must be 16-bytes aligned when loading and storing on 128bit xmm registers,  it increases the performance of SSE usage. Now we have misalign local variables, and stack register (esp). Then we have a penalty from using xmm registers. Can we do some optimization for better SSE using, e.g. 16-bytes allignment of esp and all local variables? 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.