harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pavel Pervov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-5024) [drlvm][helper] Register for Magic Helpers
Date Fri, 16 Nov 2007 08:53:43 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543002
] 

Pavel Pervov commented on HARMONY-5024:
---------------------------------------

1) Helpers without class and method names with only a descriptor look... peculiar. Why such
methods exist?
2) In init_magic_helper: change DIE message: "Exception raised while initializing helper class
" << magic_helper_class->get_name()->bytes
3) It may be good to print out exception reported in (1)
4) Do I understand correctly that load_magic_helper_class and init_magic_helper_class should
be both static?
5) Why have you changed hierarchy of helper inliners into one class?
6) Why helper inlining is turned off for x86-64? Do we support magics on x86-64 yet?

> [drlvm][helper] Register for Magic Helpers
> ------------------------------------------
>
>                 Key: HARMONY-5024
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5024
>             Project: Harmony
>          Issue Type: New Feature
>          Components: DRLVM
>            Reporter: Pavel Afremov
>            Assignee: Mikhail Fursov
>         Attachments: MagicHelperRegis.patch, MagicHelperRegis.patch, MagicHelperRegis.patch,
registry.diff
>
>
> Register for Magic Helpers implementation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message