harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Varlamov (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (HARMONY-5057) [drlvm][jvmti] Make JVMTI PopFrame platform independent and enable it on Linux x86-64.
Date Wed, 28 Nov 2007 14:08:43 GMT

     [ https://issues.apache.org/jira/browse/HARMONY-5057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Alexey Varlamov resolved HARMONY-5057.
--------------------------------------

    Resolution: Fixed

I applied the patch at revision: 599008.

Still, why do we hardcode these numbers, e.g.

port/src/lil/em64t/pim/m2n_em64t_internal.h:
#ifdef _WIN64
const unsigned m2n_sizeof_m2n_frame = 120;
#else
const unsigned m2n_sizeof_m2n_frame = 104;
#endif

vmcore/src/util/em64t/base/compile_em64t.cpp:
// Stack size should be (% 8 == 0) but shouldn't be (% 16 == 0)
const int ALIGNMENT = 0;

Doesn't it worth to let compiler calculate such values? 

> [drlvm][jvmti] Make JVMTI PopFrame platform independent and enable it on Linux x86-64.
> --------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5057
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5057
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Pavel Afremov
>            Assignee: Alexey Varlamov
>         Attachments: pop_frame_enabling.patch, pop_frame_enabling.patch, pop_frame_enabling.patch
>
>
> I've made JVMTI PopFrame platform independent  and enabled it on Linux x86-64 using fix_handler_context
method of JIT. You can find my changes in attached patch

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message