harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gshiman...@apache.org
Subject svn commit: r593487 - in /harmony/enhanced: drlvm/trunk/vm/vmcore/src/jvmti/jvmti_method.cpp jdktools/trunk/modules/jpda/src/main/native/jdwp/common/agent/commands/Method.cpp
Date Fri, 09 Nov 2007 10:45:02 GMT
Author: gshimansky
Date: Fri Nov  9 02:45:01 2007
New Revision: 593487

URL: http://svn.apache.org/viewvc?rev=593487&view=rev
Log:
Fixes for HARMONY-5099
The obsolete flag in agent has to be always initialized in false in case a function returns
error
JVMTI code shouldn't confuse obsolete methods with deprecated


Modified:
    harmony/enhanced/drlvm/trunk/vm/vmcore/src/jvmti/jvmti_method.cpp
    harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/common/agent/commands/Method.cpp

Modified: harmony/enhanced/drlvm/trunk/vm/vmcore/src/jvmti/jvmti_method.cpp
URL: http://svn.apache.org/viewvc/harmony/enhanced/drlvm/trunk/vm/vmcore/src/jvmti/jvmti_method.cpp?rev=593487&r1=593486&r2=593487&view=diff
==============================================================================
--- harmony/enhanced/drlvm/trunk/vm/vmcore/src/jvmti/jvmti_method.cpp (original)
+++ harmony/enhanced/drlvm/trunk/vm/vmcore/src/jvmti/jvmti_method.cpp Fri Nov  9 02:45:01
2007
@@ -667,9 +667,9 @@
         return JVMTI_ERROR_INVALID_METHODID;
     }
     /**
-     * Get method synthetic
+     * Since we don't have RedefineClasses yet, always return false
      */
-    *is_obsolete_ptr = (jboolean)(reinterpret_cast<Method*>(method)->is_deprecated()
? JNI_TRUE : JNI_FALSE);
+    *is_obsolete_ptr = JNI_FALSE;
 
     return JVMTI_ERROR_NONE;
 } // jvmtiIsMethodObsolete

Modified: harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/common/agent/commands/Method.cpp
URL: http://svn.apache.org/viewvc/harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/common/agent/commands/Method.cpp?rev=593487&r1=593486&r2=593487&view=diff
==============================================================================
--- harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/common/agent/commands/Method.cpp
(original)
+++ harmony/enhanced/jdktools/trunk/modules/jpda/src/main/native/jdwp/common/agent/commands/Method.cpp
Fri Nov  9 02:45:01 2007
@@ -261,7 +261,7 @@
             << ", classSignature=" << JDWP_CHECK_NULL(classSignature));
     }
 #endif
-    jboolean is_obsolete;
+    jboolean is_obsolete = JNI_FALSE;
 
     jvmtiError err;
     JVMTI_TRACE(err, GetJvmtiEnv()->IsMethodObsolete(methodID, &is_obsolete));



Mime
View raw message