harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Varlamov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-5096) [drlvm][jit]Branch translator incorrectly removes branches
Date Fri, 09 Nov 2007 06:05:50 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-5096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541238
] 

Alexey Varlamov commented on HARMONY-5096:
------------------------------------------

Yuri, the patch is not correct - it effectively disables "else if" branch on line 279:
was
if (cmpOp1->getDefScope() == Opnd::DefScope_Variable) {
...
} else if (cmpOp1->getDefScope() == Opnd::DefScope_SemiTemporary) {
and you suggested:
if (cmpOp1->getDefScope() != Opnd::DefScope_Variable) {
...
} else if (cmpOp1->getDefScope() == Opnd::DefScope_SemiTemporary) {

Please look into this.

> [drlvm][jit]Branch translator incorrectly removes branches
> ----------------------------------------------------------
>
>                 Key: HARMONY-5096
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5096
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Yuri Dolgov
>            Assignee: Alexey Varlamov
>         Attachments: HARMONY-5096.patch
>
>
> Branch translator generates invalid code for struts tests (on Harmony  r593047). It removes
valid branch and for 
> conditional jump and it leads to incorrect results.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message