harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Ellison (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-5168) [classlib][pack200] Added support for writing out line number tables
Date Thu, 22 Nov 2007 10:57:43 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-5168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544766
] 

Tim Ellison commented on HARMONY-5168:
--------------------------------------

Andrew,

I had trouble with this patch.

It appears to be missing an implementation of ByteCodeForm#hasMultipleByteCodes() required
to make it compile ok.  I defined it to return false, but then the existing tests fail with
the exceptions below.  Please can you take a look at these before the patch is accepted.

java.lang.IndexOutOfBoundsException
at java.util.ArrayList.get(ArrayList.java:336)
at org.apache.harmony.pack200.bytecode.LineNumberTableAttribute.renumberLineNumberTable(LineNumberTableAttribute.java:83)
at org.apache.harmony.pack200.BcBands.unpack(BcBands.java:368)
at org.apache.harmony.pack200.Segment.parseSegment(Segment.java:215)
at org.apache.harmony.pack200.Segment.parse(Segment.java:10)
at org.apache.harmony.pack200.tests.SegmentTest.testWithPack200E1(SegmentTest.java:82)

and 

java.lang.NullPointerException
at org.apache.harmony.pack200.ClassBands.getLineNumberAttributes(ClassBands.java:111)
at org.apache.harmony.pack200.BcBands.unpack(BcBands.java:365)
at org.apache.harmony.pack200.tests.BcBandsTest.testBcLabelBand(BcBandsTest.java:369)


> [classlib][pack200] Added support for writing out line number tables
> --------------------------------------------------------------------
>
>                 Key: HARMONY-5168
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5168
>             Project: Harmony
>          Issue Type: New Feature
>          Components: Classlib
>         Environment: All Java
>            Reporter: Andrew Cornwall
>            Assignee: Tim Ellison
>            Priority: Minor
>         Attachments: main.patch, test.patch
>
>
> The attached two patches (main and test) add support for writing out the LineNumberTableAttributes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message