Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <9357085.1191966350616.JavaMail.jira@brutus>
Date: Tue, 9 Oct 2007 14:45:50 -0700 (PDT)
From: "Aleksey Shipilev (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Commented: (HARMONY-4723) [drlvm][thread]
 hythread_self_helper wastes edx register on Linux/ia32
In-Reply-To: <6764796.1188816319736.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HARMONY-4723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533523 ] 

Aleksey Shipilev commented on HARMONY-4723:
-------------------------------------------

This is not the improvement, this is the bugfix. 
Method comment says that only eax must be preserved in this code, my patch changes the code to fulfill that requirement. 
This change makes helper usage to be correct on Linux, please see dependent issue for benchmark details.

> [drlvm][thread] hythread_self_helper wastes edx register on Linux/ia32
> ----------------------------------------------------------------------
>
>                 Key: HARMONY-4723
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4723
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>         Environment: Linux/ia32
>            Reporter: Aleksey Shipilev
>         Attachments: HARMONY-4723.patch
>
>
> Using gen_hythread_self_helper() from vm/vmcore/src/thread/helpers/thread_helpers_ia32.cpp wastes edx register on Linux/ia32. 
> Attached patch constraints register usage to eax only, that's how it going to be judging on method comment.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.