Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <4436650.1193359311181.JavaMail.jira@brutus>
Date: Thu, 25 Oct 2007 17:41:51 -0700 (PDT)
From: "Ilya Berezhniuk (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Updated: (HARMONY-5015) [drlvm][jvmti][x86_64] Functions
 jvmtiGetLocalObject and jvmtiSetLocalObject have to handle compressed
 references
In-Reply-To: <1754276.1193236251539.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HARMONY-5015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ilya Berezhniuk updated HARMONY-5015:
-------------------------------------

    Attachment: H-5015.patch

Here is the patch.

Gregory, please sheck the results. Looks like this patch actually fixes GetValuesTest, SetValuesTest and ThisObjectTest.

Also we probably need an approval from JIT guys for JIT part of this patch.

> [drlvm][jvmti][x86_64] Functions jvmtiGetLocalObject and jvmtiSetLocalObject have to handle compressed references
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5015
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5015
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Gregory Shimansky
>            Priority: Minor
>         Attachments: H-5015.patch, test.cpp, Test.exp, Test.java
>
>
> Currently these two functions treat references as void* but this isn't true on x86_64 in compressed references mode (currently default). In this mode comparison with NULL has to be done with managed_null, and references have to be uncompressed when taken from JIT stack, compressed when put into JIT stack.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.