harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pavel Pervov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-4818) first step towards Java6 BC verification: splitting existing code
Date Mon, 08 Oct 2007 09:43:51 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-4818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533078

Pavel Pervov commented on HARMONY-4818:

Re "verifier-refactoring2/patch.txt". We, probably, should throw InternalError rather than
ClassFormatError if we were unable to cfs.skip(-6). Other, than that patch looks ok to me.

> first step towards Java6 BC verification: splitting existing code
> -----------------------------------------------------------------
>                 Key: HARMONY-4818
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4818
>             Project: Harmony
>          Issue Type: New Feature
>          Components: DRLVM
>            Reporter: Mikhail Loenko
>            Assignee: Mikhail Loenko
>         Attachments: verifier-refactoring.zip, verifier-refactoring2.zip
> as Alexei F noted somewhere Java6 verifier might be obtained from Java5 verifier
> mostly by removing some code.
> Since we all don't want code duplication, it makes sense to split current verifier to
> common part that will be used by both Java5 and Java6 verifiers and Java5-specific
> part.
> I've made such a separation and here is the code for review.
> The modifications made are mostly splitting the files and moving unmodified pieces
> of code around. So, I submitted 'code' rather then 'patch'.
> _base suffix or no suffix means that it's a base part, common for both verifiers
> _x suffix means that the same code operates with different types, it's written with templates.
There are 2000+ lines of such a code. 
> _5 suffix means pure Java5 code
> I've created a new namespace for _5 code, so that later I'll create different 
> Java6-specific types with the same names in Java6-specific namespace
> Please review the code.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message