Return-Path: Delivered-To: apmail-harmony-commits-archive@www.apache.org Received: (qmail 89071 invoked from network); 2 Sep 2007 06:29:40 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 2 Sep 2007 06:29:40 -0000 Received: (qmail 47015 invoked by uid 500); 2 Sep 2007 06:29:35 -0000 Delivered-To: apmail-harmony-commits-archive@harmony.apache.org Received: (qmail 46990 invoked by uid 500); 2 Sep 2007 06:29:35 -0000 Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list commits@harmony.apache.org Received: (qmail 46981 invoked by uid 99); 2 Sep 2007 06:29:35 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 Sep 2007 23:29:35 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 02 Sep 2007 06:29:39 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id F14F7714163 for ; Sat, 1 Sep 2007 23:29:18 -0700 (PDT) Message-ID: <27874001.1188714558977.JavaMail.jira@brutus> Date: Sat, 1 Sep 2007 23:29:18 -0700 (PDT) From: "Sergey Dmitriev (JIRA)" To: commits@harmony.apache.org Subject: [jira] Commented: (HARMONY-4705) [drlvm][jni] JNI transition uses ineffective TLS get In-Reply-To: <7923674.1188557310532.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HARMONY-4705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524323 ] Sergey Dmitriev commented on HARMONY-4705: ------------------------------------------ FYI: unfortunately Oracle Application Server's startup is not OK with the JNI-tls-1.patch. It hangs up, quote: -------- 07/09/02 10:26:42 Start process -------- GC use large pages. WARNING: Cannot cleanup application URLStreamHandlers. > [drlvm][jni] JNI transition uses ineffective TLS get > ---------------------------------------------------- > > Key: HARMONY-4705 > URL: https://issues.apache.org/jira/browse/HARMONY-4705 > Project: Harmony > Issue Type: Improvement > Components: DRLVM > Reporter: Aleksey Shipilev > Attachments: JNI-tls-1.patch > > > For now, JNI transition uses ineffective scheme of TLS getting - it is done via several recursive calls, finally reaching hythread_self(). > The idea is to inline helper for TLS get instead of calling get_thread_ptr_stub(). Disassembly shows that 10 push/pops and 3 calls are completely eliminated there, keeping in mind that TLS get occurs at least 3 times on each JNI transition this give us a huge boost, eliminating up to 30 push/pops and 9 calls. > JNI microtest (calling several millions of empty JNI methods) testifies this: > $ ../../Builds/Harmony-clean/bin/java -cp . -Xmx128m -Xms128m nalog.nalog > iteration: 0 millis:8763 > iteration: 1 millis:8722 > iteration: 2 millis:8833 > $ ../../Builds/Harmony-fastTLS-1/bin/java -cp . -Xmx128m -Xms128m nalog.nalog > iteration: 0 millis:6780 > iteration: 1 millis:6689 > iteration: 2 millis:6870 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.